- 🇩🇪Germany Christian.wiedemann
I updated the patch. In my case a taxonomy view without relationships crash with the "Drupal\views_parity_row\Plugin\views\Entity\Render\TranslationLanguageRenderer::preRenderByRelationship() in"
The patch fixes the issue.
- Status changed to Needs review
about 2 years ago 11:32am 1 March 2023 - 🇨🇭Switzerland weri
I updated the patch for the latest version of views_parity_row.
- Status changed to RTBC
over 1 year ago 7:52am 20 October 2023 - 🇨🇭Switzerland weri
The patch from Christian.wiedemann (mine is similar) looks good to me and it solves the problem. Hope you can merge it soon.
- Status changed to Needs work
over 1 year ago 6:43pm 20 October 2023 - 🇧🇪Belgium pol Brussels
Hi,
What are the advantages of providing a patch, it gives you more work, no? What are the benefits?
Anyway, could you please provide a MR instead so we can review/merge it?Thanks!
- First commit to issue fork.
- @karlshea opened merge request.
- Status changed to RTBC
over 1 year ago 10:12pm 2 November 2023 - 🇺🇸United States karlshea Minneapolis 🇺🇸
> What are the advantages of providing a patch, it gives you more work, no? What are the benefits?
Until we can target a specific change from GitLab it can be less risky to reference a patch in composer instead of a GitLab diff which can change at any time.
In any case, now there's a MR.
- 🇧🇪Belgium pol Brussels
No that's wrong. You CAN actually target a specific change in Gitlab.
For example, the commit you just created in your MR, add a `.patch` at the end, and you have your patch!
=> https://git.drupalcode.org/project/views_parity_row/-/commit/7e3d97c8e3c...
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Anything what holds back to merge to latest dev to be fixed?
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Should this be considered a BC break, or can we commit this without a problem?
