Account created on 14 March 2009, over 15 years ago
  • Senior Program Manager at Acquia 
#

Merge Requests

More

Recent comments

🇺🇸United States grasmash

Based on some more review, it's more accurate to say that a user has both the authenticated and premium roles, not that premium inherits from authenticated. Therefore, the solution would be to grant the authenticated role to the token as well as the premium role.

🇺🇸United States grasmash

If I had to guess I'd say this broke it:
https://git.drupalcode.org/project/mailchimp/-/compare/2.2.2...2.2.3?fro...

The code seems to assume that if "allow_unsubscribe" is not present and true, then there must be no subscription happening. That's not true. Subscription can be mandatory.

🇺🇸United States grasmash

I’m not currently a maintainer. Happy if someone else maintains it. Let me know if there’s someway I can help.

🇺🇸United States grasmash

The performance post depends completely on the application. It should be much faster for applications that have large number of dependencies, because optimizing the auto loader reduces disk reads during autoloading.

This is the best practice recommended by composer itself for production applications. Also, don’t think there’s any downside to it. The only time that you should not optimize the auto loader is when you are working in a development environment, because the dynamic file discovery makes it easier during development to create new files, change names, etc., without having to dump the auto loader each time you make a change.

See https://getcomposer.org/doc/articles/autoloader-optimization.md#:~:text=....

🇺🇸United States grasmash

This happens because for some reason, _unwanted_email_registration_filter_email() is called twice. The first time $email is properly populated, the second time it is NULL.

PHP 8.2, Drupal 10.2.3.

🇺🇸United States grasmash

I don't understand how this can be achieved in 6.0. The goal is to dynamically assign scopes based on the user role. The ability to add default roles per consumer does not achieve assigning default roles per user -- users of different roles may use the same consumer.

🇺🇸United States grasmash

Related changes were made here: https://www.drupal.org/project/achievements/issues/3182487 🐛 Form fails on drupal 9 because of non-existing method Fixed

Is this still an issue?

🇺🇸United States grasmash

Doesn't this need an update hook for existing achievement entities?

🇺🇸United States grasmash

I'd consider this a bug -- there should be a clear error message. But, you can resolve this by creating a key as per the instruction on the project page:

Signing and/or validating JWTs requires a secret. The JWT module leverages the key module to manage these secrets. Once everything is installed, you will need to create a new key at Manage > Configuration > System > Keys (admin/config/system/keys). Add a new or existing key there.

and

Once you have created a key, navigate to Configuration > System > JWT Authentication (admin/config/system/jwt). Choose the key that you just created in the previous step.

🇺🇸United States grasmash

@jurgenhaas, @sanduhrs any chance you can tell me how to actually get the id token? /oauth/token only returns the access token.

🇺🇸United States grasmash

The patches in this PR seem to do more than resolve BC issues, they introduce new support for ID tokens and ISS claims. Valuable stuff, but a separate issue?

>The OpenID Connect token id response needed some treatment as-well.

I'd love to see those parts merged.

🇺🇸United States grasmash

It amazes me how unintuitive IAM is. In case this helps someone else, I had to define a policy for my user like this:

{
	"Version": "2012-10-17",
	"Statement": [
		{
			"Sid": "VisualEditor0",
			"Effect": "Allow",
			"Action": [
				"s3:PutObject",
				"s3:GetObjectAcl",
				"s3:GetObject",
				"s3:DeleteObjectVersion",
				"s3:DeleteObject",
				"s3:PutObjectAcl",
				"s3:GetObjectVersion"
			],
			"Resource": "arn:aws:s3:::[bucket-name]/*"
		},
		{
			"Sid": "VisualEditor1",
			"Effect": "Allow",
			"Action": [
				"s3:ListBucketVersions",
				"s3:ListBucket"
			],
			"Resource": "arn:aws:s3:::[bucket-name]"
		}
	]
}
🇺🇸United States grasmash

Works well for me. Any reason not to commit?

🇺🇸United States grasmash

I would find the feature very valuable.

From my use case, in which user uses basic authentication to retrieve a json web token, invalidating the Web token when the user changes their password would make a lot of sense.

🇺🇸United States grasmash

IMO the README needs to be extended to show how to obtain a JWT using example HTTP requests.

🇺🇸United States grasmash

Honestly, I'm not sure what's up with this. Removing the offset entirely seems to fix it. I think the dates are already saved in the DB as UTC, and they're fetched as UTC, so there's no need to offset.

🇺🇸United States grasmash

No problem. Thanks for maintaining this module.

🇺🇸United States grasmash

Issue is that cleanVar() is set to accept only strings. But in the function body, it clearly expects to receive an object as it immediately checks for a ->last_render property.

🇺🇸United States grasmash

Looks like the info.yml file is the only issue here. If you're blocked on a Drupal 10 upgrade by this module, you can use Using Drupal's Lenient Composer Endpoint .

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/views_future_past_date_sort"]'
🇺🇸United States grasmash

Looks like the info.yml file is the only issue here. If you're blocked on a Drupal 10 upgrade by this module, you can use Using Drupal's Lenient Composer Endpoint .

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/discord_widget"]'

🇺🇸United States grasmash

For RC2, accessing the "general" tab of a variant causes this error with the patch:

Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing ("page_variant") to generate a URL for route "entity.page_variant.clone_form". in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 181 of core/lib/Drupal/Core/Routing/UrlGenerator.php).

🇺🇸United States grasmash

Sorry, I've got to revert this. It looks like the correct file name was the one that already existed. We can update that.

🇺🇸United States grasmash

Good idea, I have a similar use case where I'm displaying a slideshow via an entity reference field, and I'd like to configure the field formatter config per entity.

🇺🇸United States grasmash

grasmash made their first commit to this issue’s fork.

🇺🇸United States grasmash

I've submitted the MR but I understand that the changes I made don't align with your plan. My approach was to replace existing config fields with a single JSON field. Alternatively, perhaps we could add a field like "Config mode" that lets the the user can choose between defining config as JSON or as fields. Fields would be displayed conditionally based on that decision.

🇺🇸United States grasmash

I’m working on a merge request.

🇺🇸United States grasmash

Note, this only works if you have the core basic_auth module enabled.

🇺🇸United States grasmash

I added you. The interface is not exactly mobile friendly, but I think I granted you all of the required roles.

🇺🇸United States grasmash

Hello! Yes I’d be happy to make you a co maintainer. I’m out of the county for the week… I’ll see if I can add you via my phone :)

Production build 0.69.0 2024