Improve flood block error output

Open on Drupal.org →

Created on 6 December 2023, about 1 year ago

Updated 19 September 2024, 3 months ago

Problem/Motivation

Currently when logging in via credentials, the /oauth/token returns a 'The user credentials were incorrect.' message regardless of whether the attempt was blocked by the flood module, or if the user really supplied wrong credentials.

Proposed resolution

Make sure to generate different responses depending on whether the login attempt was blocked or not.

✨ Feature request

Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇹Austria chfoidl Salzburg

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!1Improve flood block error output
Merged
🇺🇸United States grasmash
updated 3 months ago

Comments & Activities

Issue created by @chfoidl
Comment 3 months ago →
🇺🇸United States grasmash
Yes. Very confusing.
Merge request !1Issue #3406510: Improve flood block error output → (Merged) created by grasmash
Pipeline finished with Failed
3 months ago
Total: 127s
#286726
Status changed to Needs review 3 months ago1:35am 19 September 2024
Comment 3 months ago →
🇺🇸United States grasmash
Pipeline finished with Failed
3 months ago
Total: 104s
#286730
Comment 3 months ago →
System Message

chfoidl → committed 3eb5d5a2 on simple_oauth_password_grant-3406510-3406510-improve-flood-block
Issue #3406510: fix errors
Comment 3 months ago →
System Message

chfoidl → committed 7272029f on simple_oauth_password_grant-3406510-3406510-improve-flood-block authored by grasmash →
Issue #3406510: Improve flood block error output
Comment 3 months ago →
System Message

chfoidl → committed 7b0d54a7 on 1.x authored by grasmash →
Issue #3406510: Improve flood block error output
Comment 3 months ago →
🇦🇹Austria chfoidl Salzburg
Hi @grasmash!

Thank you for your contribution.
I made some additional tweaks to your code:

Added unique error code for each flood block response.

Updated tests
Status changed to Fixed 3 months ago8:01am 19 September 2024
Comment 3 months ago →
🇦🇹Austria chfoidl Salzburg
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024