Will not work if JSON:API route prefix has been modified

Open on Drupal.org →

Created on 26 March 2025, 3 months ago

Problem/Motivation

If the path prefix for JSON:API has been customized, the module will break. See https://git.drupalcode.org/project/jsonapi_query_builder/-/blob/1.0.x/sr...

  public function explorer() {
    $base_url = Url::fromRoute('<front>', [], ['absolute' => TRUE])->toString();
    $jsonapi_url = $base_url . 'jsonapi';

Steps to reproduce

Proposed resolution

Generate the URL from the jsonapi.resource_list route with setAbsolute.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States mglaman WI, USA

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!3Will not work if JSON:API route prefix has been modified
Merged
🇺🇸United States balsama
updated 14 days ago
!2Will not work if JSON:API route prefix has been modified
Open
🇺🇸United States grasmash
updated 20 days ago
!1Will not work if JSON:API route prefix has been modified
Open
🇺🇸United States mglaman
updated 20 days ago

Comments & Activities

Issue created by @mglaman
Merge request !1Generate baseUrl from correct entrypoint route → (Open) created by mglaman
Comment 3 months ago →
🇺🇸United States mglaman WI, USA
Pipeline finished with Failed
3 months ago
Total: 380s
#458227
Pipeline finished with Failed
3 months ago
Total: 304s
#458230
Comment 3 months ago →
🇺🇸United States mglaman WI, USA
There is to this in App.js

https://git.drupalcode.org/project/jsonapi_query_builder/-/blob/1.0.x/js...

I don't know why jsonapi is hardcoded here. Especially when a URL object could be used to pop the path from the absolute URL passed in. It's also duplicated in https://git.drupalcode.org/project/jsonapi_query_builder/-/blob/1.0.x/js...
Status changed to Needs work 20 days ago4:47pm 3 June 2025
First commit to issue fork.
Pipeline finished with Failed
20 days ago
Total: 38s
#513493
Pipeline finished with Failed
20 days ago
Total: 39s
#513494
Pipeline finished with Failed
20 days ago
Total: 220s
#513492
Merge request !2Issue #3515617: Will not work if JSON:API route prefix has been modified → (Open) created by grasmash
First commit to issue fork.
Merge request !3Resolve #3515617 "Balsama" → (Merged) created by balsama
Comment 15 days ago →
🇺🇸United States balsama boston
Started a new branch that allows this to work with customizations to jsonapi.base_path and when running Drupal in a subdirectory.
Comment 14 days ago →
🇺🇸United States mglaman WI, USA
Looks good to me! Combines needed fixes from https://git.drupalcode.org/project/jsonapi_query_builder/-/merge_requests/1 and https://git.drupalcode.org/project/jsonapi_query_builder/-/merge_requests/2 plus more fixes.
Comment 14 days ago →
System Message

grasmash → committed 99c0ac86 on 1.0.x authored by balsama →
Resolve #3515617 "Balsama"
Comment 14 days ago →
🇺🇸United States grasmash
Comment 5 days ago →
🇵🇱Poland skinio
Great fix. Please make it as a release becouse v1.0.1 witch is installed as default is way behind :/

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024