Thanks for testing @bronismateusz
Apologies @nginex I didn't know about the tick box! Thanks so much for your work on this :)
Hopefully this has credited you now? (I added you to the git commit, I thought that did it)
Hi qtarant, can you post the code you changed? Or supply a patch? Many thanks
I'm interested in this functionality so very pleased to see it's an active issue again. I'm just making a comment so I get alerted on updates and to say thanks!
Need to patch this, but some other issues with getting the latest version :/
So for now if you have the same issue, change responsive_menu.libraries.yml
from
...
responsive_menu.toolbar:
version: VERSION
js:
js/views/ToolbarVisualView.js: {}
To:
...
responsive_menu.toolbar:
version: VERSION
js:
js/views/ToolbarVisualView.js: {}
dependencies:
- toolbar/toolbar
code-brighton → created an issue.
code-brighton → created an issue.
I can confirm this patch works. I had the same issue that had me confused for days, it seemed like a random issue, but thank you for this great work, I was able to consistently recreate the issue (by filtering so I got an empty result, which then cached the view always as empty) Using the merge request patch the issue was solved. Thank you @selvira !
Hi great stuff,
Can someone help me with a use case where I want to whitelist this range of IPs:
59.26.62.25 > 59.56.62.128
How do i write that?
Grevil → credited code-brighton → .
Should be ok now, I rebased
Allow IP ranges to be entered in the allow list e.g. 127.0.0.1>127.0.55.255
code-brighton → created an issue.
@alayham I understand your reasoning here, I see the other branch is a more straightforward solution, but due to my requirements that I don't want to give the wide ranging 'administer site configuration' permissions to the user role that needs to administer the allowed IPs OR even give them the administration rights to setting the "Ban URL patterns" if that became a separate permission for this module. So I will stick to this branch for my use-case for now.
D10 version
Added patch from merge request
patch attached!
Added patch from merge request that passed tests after fix to test!
@newswatch it's for the 3.x branch of this module (but patch might work on old version?) but you might find the work I've done in this issue to whitelist IPs useful? https://www.drupal.org/project/perimeter/issues/3394429 ✨ An IP Whitelist / Allowlist Active
I didn't want to give 'administer site configuration' permissions to the user role that needs to administer the allowed IPs list so I created a new route for just the Allowed IPs list config with a new permission 'administer perimeter defence allowed ips'
Patch created from merge request attached.
Created an allowed list of IPs in the config settings at /admin/config/system/perimeter. Patch (from merge request) attached.
code-brighton → created an issue.
code-brighton → created an issue.
code-brighton → created an issue.
I have this same issue in Drupal 9 (9.5.10)