- Issue created by @douggreen
- πΊπΈUnited States douggreen Winchester, VA
The tricky part of this is to figure out the best way to define IP ranges.
- Status changed to Needs review
over 1 year ago 12:20am 31 May 2023 - πΊπΈUnited States douggreen Winchester, VA
Symphony to the rescue, yay! We can use IpUtils::checkIp(). I've created a merge-request that is ready for review.
- Merge request !9Issue #3363678: Add allowed IP configuration to prevent banning certain IP's β (Merged) created by douggreen
- last update
over 1 year ago 2 pass - last update
over 1 year ago 2 pass - π©πͺGermany Anybody Porta Westfalica
@douggreen: Impressive work! Super helpful addition!
Did you test this manually and ensure it works as expected? Do you see any chance for tests in β¨ Write functionality tests Needs review to check this?
One more question: Should we perhaps add a link to the IpUtils documentation page to show, which formats are allowed? I think for technical people that information might be helpful?
- πΊπΈUnited States douggreen Winchester, VA
I've been running this on a production site since making the patch. A link to IpUtils makes sense. Can you add that? And for tests, I'd prefer that someone else writes them ... if you require them and don't want to write them yourself, I'll ask someone else on my team to do it, but I'd also prefer that you do that too ... since this patch does what I need.
- πΈπͺSweden alayham
This is an impressive work indeed. Very short and easy to understand and maintain. I have tested the fork on a live site, and it works as expected.
I would love to mark this as RTBC, but it is not mergeable. I tried rebasing it, and it is not rebaseable as well.
I think it is easier to manually copy the changes to a new branch. - Status changed to Needs work
about 1 year ago 12:02am 29 October 2023 - last update
about 1 year ago 2 pass - Status changed to Needs review
about 1 year ago 4:16pm 22 November 2023 - πΊπΈUnited States douggreen Winchester, VA
I rebased and force pushed.
- last update
about 1 year ago 7 pass - last update
11 months ago 7 pass - π¬π§United Kingdom code-brighton
Grevil β credited code-brighton β .
- Assigned to Grevil
- π©πͺGermany Grevil
As discussed in β¨ An IP Whitelist / Allowlist Active , I'll adjust the code to conform with the requirements of that issue.
- Status changed to Needs work
11 months ago 1:30pm 9 January 2024 - last update
11 months ago 7 pass - last update
11 months ago 7 pass - last update
11 months ago 7 pass - π©πͺGermany Grevil
Alright, all done and tested! (Also the update hook).
Please review!!
- Issue was unassigned.
- Status changed to Needs review
11 months ago 2:49pm 9 January 2024 - last update
11 months ago 7 pass - last update
11 months ago 7 pass - Status changed to RTBC
11 months ago 4:01pm 9 January 2024 - π©πͺGermany Anybody Porta Westfalica
Great work once again! Thank you @Grevil! :)
-
Grevil β
committed ebf0b649 on 3.x authored by
douggreen β
Issue #3363678: Add allowed IP configuration to prevent banning certain...
-
Grevil β
committed ebf0b649 on 3.x authored by
douggreen β
- Status changed to Fixed
11 months ago 9:39am 10 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- π¬π§United Kingdom code-brighton
Hi great stuff,
Can someone help me with a use case where I want to whitelist this range of IPs:
59.26.62.25 > 59.56.62.128
How do i write that?
- π©πͺGermany Anybody Porta Westfalica
@code-brighton meta-answer: Did you ask Chat-GPT perhaps? Seems this would be a good idea ;) (but check the result)
- π«π·France dqd London | N.Y.C | Paris | Hamburg | Berlin
@#23: Sorry, but could you please consider to rephrase your answer to the previous commented question with a more respectful attempt? Examples can be found at https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... β under #Constructive review comments
@all: testing this on Drupal 11 with the merge from the Drupal 11 compatibility issue it seems the whitelisted IP gets ignored (not whitelisted).
Also the description below the field is far too cryptic and needs work. It should also hold examples with simple IPs like 123.34.34.14 so that users are not confused by the trailing number behind a slash (/23) exaples, which is not like IPs look like in the banned ip table.
- π©πͺGermany Anybody Porta Westfalica
@dqd, sorry that wasn't meant disrespectful in any way. I think it's just something AI can help with very well. Of course you're right, I should have run that question and place the answer here. Thank you, @dqd