🇪🇸Spain @cesarmsfelipe

Hi, I have managed to reproduce the error.
I have solved it by changing the language of the structure sync configuration, which by default is set to ‘en’ and my site was using ‘es’, by changing that, importing configuration and importing custom blocks (full), the edit and delete works correctly.

Merged the feature into the main branch and created tag 1.0.3 for further testing.

I know it's not good practice, we are treating this as a hotfix so next time it should be done in 1.0.x-dev version.

Merged the feature into the main branch and created tag 1.0.2 for further testing.

Thanx @davidjguru.

Worked for me in Drupal 11.0.5! thanks

Hi, I am encountering the same problem when hiding an element. The patch works for me in Drupal version 10.3.6. Thank you.

Thanks @ovilla, working for me in Drupal 10.3.5.

Hi @avpaderno sorry I thought it wasn't necessary as it is null setted by default in the configFormBase.

However, I have added it, thanks for the feedback.

Thank you for the feedback. I have made the necessary changes as you suggested:

IdpConfigForm Constructor: I have updated the constructor to call the parent class's constructor and included the setLoggerFactory() method to ensure proper initialization.

sso_connector.info.yml: I have reviewed and adjusted the core_version_requirement.

Please let me know if there are any further adjustments needed.

Hi @karma0321, you are right, the structure needed that improvement.

I have made the following adjustments to the HierarchicalTermSelectorHelper.php file:

• Updated the `#wrapper_attributes` to change the class from 'hts-select' to 'container'.
• This change was implemented to ensure consistency with the CSS structure and to eliminate any redundancy by removing the attached CSS library that was no longer necessary.

These modifications aim to streamline the styling and improve the clarity of the HTML output generated by the form elements. If there are any further refinements needed or additional feedback, please let me know.

One more thing, could you check if the generated structure meets the needs of this issue? I’m moving the issue to "Needs Review," and the changes have been merged into the 1.0.x branch.

cesarmsfelipe → made their first commit to this issue’s fork.

Hello @SirClickalot

Thanks for the feedback and nice words about the module. I think your request is out of the scope of this module, as the module only tests a custom widget and a view filter to handle multi-level taxonomies, but does not affect the taxonomy edit page. Maybe you can open a topic in Hierarchy Manager → to request to keep the expanded level on reload.

As I told you, I am closing this issue because it is not within the scope of this module, I will be happy to receive more feedback or requests in the future.

Oh sorry for the inconveniences, i though all projects should go through this process to get promoted and get security badge, thanks @vishal.kadam

cesarmsfelipe → created an issue.

cesarmsfelipe → created an issue.

Should it be in Reviewed and tested by the community? @vishal.kadam

Thanks for your help and work @mortona2k, and sorry for the delay in replying. I hope the module works for you and I would appreciate if you have suggestions for improvements for it. Best regards!

Thank you for your review and your time @apaderno, I correct the errors you have reported and I am always open to suggestions that can improve performance and security.

Hi @mortona2k, Can you give me more information about the problem, I have three websites with the module in place, and I don't get the same error you describe, as I have the latest beta version.
If you need to check something, try to debug the SsoController.php, but the error you described above is fixed with the latest version, at least in my case.
Try to give me some more information so I can help you, thanks!

Hi @vishal.kadam, how is the process going, is it normal to take so long? Sorry for being insistent, this is the first time I apply for this review process.

Hi @mortona2k, I have checked the problem you report and there should no longer be a problem with synchronization disabled. I have also overwritten the behavior of the cookie provided by the core to avoid this error. I'm going to create a new beta3 tag, can you test if the problem is solved? Thank you.

I have retested the whole process. I have fixed and refined some parts of the synchronization code, now it will work even if the user does not exist in the SP. Can you try with beta2 tag. Thanx!

Hi, thanks @mortona2k, glad to hear it's working for you. Regarding the user synchronization, you should have the box checked in both IdP and SP, they are both checked and you still have that error?

Hi @mortona2k, I have made some changes that fix the problem, adding routing and fixing some user sync issues. Could you try with the beta1 tag and check if you can now use the module correctly?

cesarmsfelipe → made their first commit to this issue’s fork.

@apaderno Thanks for your review, I have changed the license using the drupalcode template for version 2.

Thank you both for the feedback, I have solved all the phpcs requirements, deleted wrong branches and fixed the standard comments. Let me know if there is something else to change or improve.

cesarmsfelipe → created an issue.

Thanks benabaird, I've tested the custom removal method as per the documentation you provided, and it worked correctly for me.

Attached is a patch that improves handling of Select2 elements when removing a specific active filter, rather than clearing all values. This patch specifically adjusts the behavior for 'select' type fields to check for Select2 data and properly filter out the value to be removed, maintaining the rest of the selections intact. This change aims to enhance the usability and functionality of the Active Filters module when used with Select2 elements provided by BEF.

I've tested the patch on 1.0.0-rc2, and it successfully allows individual active filters to be removed from Select2 fields without affecting other selected values.

I would appreciate further testing and review.

cesarmsfelipe → created an issue.

Hi everyone,

I encountered an issue where both the select2 and webform Drupal 9 modules required the same JavaScript library (jquery.select2), but it was only being fetched and stored for the webform module in web/libraries/jquery.select2. The select2 module, however, was expecting this library to be in web/libraries/select2, which led to a dependency resolution problem.

To solve this, I implemented a solution using a symbolic link, created by a script executed via Composer's event hooks. This approach ensures that the select2 module can correctly locate and use the jquery.select2 library without needing to duplicate the library files.

Here's the script that creates the symbolic link (scripts/fix_select2_dependency.php):

<?php

$source = __DIR__ . '/../web/libraries/jquery.select2';
$destination = __DIR__ . '/../web/libraries/select2';

// Check if the destination directory exists, create it if it doesn't
if (!file_exists(dirname($destination))) {
mkdir(dirname($destination), 0755, true);
}

// Create a symbolic link if it does not already exist
if (!is_link($destination)) {
symlink($source, $destination);
echo "Symbolic link created: $destination -> $source\n";
}

And these are the modifications to composer.json to invoke the script after install and update events:

"scripts": {
"post-install-cmd": [
"php scripts/fix_select2_dependency.php"
],
"post-update-cmd": [
"php scripts/fix_select2_dependency.php"
]
}

I hope this solution helps anyone facing a similar issue. Feel free to adjust the script paths according to your project's directory structure.

+1 Applying the patch from the MR solved the issue, please merge!

I strongly agree with @pdjohnson.

Also, incorporating a short survey to gauge user experience level and specific interests in Drupal could enrich the data collected, leading to better contribution opportunities.

This approach could encourage mentoring programs and contribution opportunities early on.

cesarmsfelipe → created an issue.

The patch works for me on Drupal 10.1.5, but I'm adding it using the mglaman/composer-drupal-lenient composer plugin.