Contrib.social

Repeated class on filters select elements

Open on Drupal.org ā†’
Created on 16 August 2024, 3 months ago
Updated 18 August 2024, 3 months ago

Problem/Motivation

The HTML structure generated with select elements has a repeated class `hts-select` that leads to confusion and can be improved.

Proposed resolution

Replace inner element class with some more specific name, like e.g. `hts-select-item`

https://git.drupalcode.org/project/hts/-/blob/1.0.x/src/HierarchicalTerm...

šŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

šŸ‡ŖšŸ‡øSpain karma0321

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

Sign in to follow issues

Comments & Activities

  • Issue created by @karma0321
  • First commit to issue fork.
  • Assigned to cesarmsfelipe
  • Status changed to Needs review 3 months ago
  • Comment 3 months ago ā†’
    šŸ‡ŖšŸ‡øSpain cesarmsfelipe

    Hi @karma0321, you are right, the structure needed that improvement.

    I have made the following adjustments to the HierarchicalTermSelectorHelper.php file:

    • Updated the `#wrapper_attributes` to change the class from 'hts-select' to 'container'.
    • This change was implemented to ensure consistency with the CSS structure and to eliminate any redundancy by removing the attached CSS library that was no longer necessary.

    These modifications aim to streamline the styling and improve the clarity of the HTML output generated by the form elements. If there are any further refinements needed or additional feedback, please let me know.

    One more thing, could you check if the generated structure meets the needs of this issue? Iā€™m moving the issue to "Needs Review," and the changes have been merged into the 1.0.x branch.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024