🇷🇴Romania @rares petru samartean

If your website has at least one user
# with the Administrator role...

This is quite misleading. This does nothing if the user uid 1 has the Administrator role.
What this setting does is: if the user uid 1 does not have the Administrator role, it's no longer granted all permissions as it usually is, as I understand from the Drupal site.
Related: https://www.drupal.org/project/drupal/issues/3485663 🐛 Warn if security.enable_super_user is false and UID 1 has an administrator role Active
If uid 1 has an administrator role this setting does nothing.
I appreciate the change though, this is useful.

Thank you so much for this. I just spent the past hour wondering if I'm misspelling something because my uid 1 had the Admin role. This should at least be mentioned here https://www.drupal.org/node/2910500 →

Seems to me like this is a Drupal core / ckeditor5 issue then, first and foremost. Modify the issue as you see fit :-) Perhaps you'd like to use it to remember to test the functionality once embedding multiple images becomes supported.

I believe the patch in #147 doesn't allow the generation of image styles as it is not using the standard image style generation function. I found this which goes in detail https://www.unimitysolutions.com/insights/image-style-token-itok-and-drupal . I have this issue on my Drupal backend.

Bolded steps because they were barely visible.

Added some issues for clarity. To be fair it kind of looks like you need to work with the media module devs to get this sort of thing integrated, so maybe this ticket should be posted in their issue queue instead.
Also the more I look at this the more it looks like a headache haha.
Module works nicely with paragraphs and your usual images anyway, you just have to make your content editor aware that they need to scale the images they will upload properly.

Also, thank you for your work!

rares petru samartean → created an issue.

rares petru samartean → created an issue.

Thank you. This option causes such confusing errors that it should probably be removed from the default development.services.yml, or devs should be warned at least..

If you get yourself in a situation where this happens to you, one way or another:

• drush cex from your initial, broken state, where the entity type is not supposed to exist
• recreate the entity with that machine name; fields are unnecessary
• drush cim; this should delete the entity type while syncing config and fix your issue without errors

devel_entity_updates and normal drush cim to remove the entity did not work for me.
If you still get errors and this doesn't work, good luck

Hi again. I'm not sure about setting the path using settings.php since it's not actually a path but a file ID, but I still think I found the issue.

The generated file was being set as temporary. What I did was loading the file by ID in the submit handler of the configuration form, setting it as permanent, then saving it, then setting the file id as the credentials_path config.

Hope this helps. I can't contribute code from my workplace but that should be good enough for you guys to have at it. Thank you for your contributions!

Perhaps this is not proper reporting but I should mention it.

The google credentials file does not stay set properly. I added it in the configuration form, the form saved properly and I could see it saved.
After a bit of time I noticed I was no longer getting notifications from my local env, even though I was getting them before.
I went to check the form and saw that a different, random PNG file was assigned instead of the credentials file.
I readded it and moved on.
After a while, again, instead of being reassinged randomly, it got deleted completely and was no longer appearing as set in the form.

I haven't looked into why it happens yet. I used the v10 patch from #13.
Also, setting the config value programatically using something like

$settings['firebase.settings']['credentials_path'] = 'private://firebase/inkjin-e4091-84c8a56e2a6c.json';

doesn't seem to work, or it at least doesn't get recognised in the form. I don't know which one exactly yet as I'm pretty overwhelmed.

Hope this helps you guys. I'll post a fix if I ever find the time to I hope.

Nevermind my above comment. It seems that text editor code is not yet adapted, to me at least. I don't know exactly how external libraries loading works but it seems the module is currently trying to load libraries that aren't defined anywhere, in src/Plugin/Editor/AceEditor.php line 166:

    $theme_exist = \Drupal::service('library.discovery')->getLibraryByName('ace_editor', 'theme.' . $theme);
    $mode_exist = \Drupal::service('library.discovery')->getLibraryByName('ace_editor', 'mode.' . $mode);

So I'm assuming, as it was said above, this is just not updated yet.

To anyone else having trouble with this, from the module readme:

If you want Composer to automatically download the Ace Library
to the /libraries folder when installing the module, you must
update your root project composer.json in the following sections:

"extra" section: add the following:

"installer-types": [
"npm-asset"
],
"installer-paths": {
"libraries/{$name}": [
"type:drupal-library",
"type:npm-asset"
]
}

"repositories" section: add the following:

"assets": {
"type": "composer",
"url": "https://asset-packagist.org"
}

(see details: https://www.drupal.org/docs/develop/using-composer/using-composer-to-ins... → )

After the previous updates, run:

$ composer require 'drupal/ace_editor:^1.0'

or

$ composer require 'drupal/ace_editor:1.x-dev'

The Ace library will be downloaded to the /libraries folder
with '$ composer install/update'. Only one version
(minified, noconflict...) is required. Other folders
(including /demo) can be removed.

For anyone using a view that displays rendered content instead of individual fields, you can also fix this issue by checking "Correct faulty and chopped off HTML" on the configuration page of the used text editor. Example link if you're using an editor called "full_html": admin/config/content/formats/manage/full_html

Rares Petru Samartean → created an issue.

I'm now getting this issue as well, on Linux, using a search_api index. It used to work a second ago and now it doesn't. I will update when I find a way to solve it.

I'm also having this issue. I cannot save the module configuration.

Latest Firefox gives a distinct JS warning:

10:10:15.972 Uncaught DOMException: Operation is not supported ckeditor.js:97
A http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:97
setTimeout http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:9
(Async: setTimeout handler)
setTimeout http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:9
U http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:98
addFunction http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:10
callFunction http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:10
http://local.tiff.reea/admin/config/system/eu-cookie-compliance line 13 > injectedScript:15
write http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:13
S http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:98
m http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:6
fire http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:6
prototype http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:12
(Async: EventListener.handleEvent)
on http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:12
S http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:98
loadData http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:100
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:100
setMode http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:127
init http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:127
m http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:6
fire http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:6
fire http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:7
fireOnce http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:6
fireOnce http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:7
build http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:148
u http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:25
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
t http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
u http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:25
s http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:25
t http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
s http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:25
p http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
t http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:22
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
p http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
p http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23
load http://local.tiff.reea/sites/all/libraries/ckeditor/ckeditor.js?rsj2ko:23

Chrome also gave me JS errors (not warnings) the first time I installed the module and went to the module configuration page, though I can no longer replicate them after messing with the configuration page to try to get it to work.
Chrome errors mentioned something about 5 non-focusable text areas being invalid.

What I did in Chrome was:

• changed the text formats to a custom one that allows PHP
• filled required fields and ticked all of the user roles
• saved

and then the page refreshed, I was given a green success message at the top of the page, but none of my changes saved and I was back at square 1, except the errors were gone.

In Firefox it's still the same. In Chrome it gives me no errors but saving doesn't work even though it's giving me a green success message. I tried reinstalling the module several times, clearing cache etc, but nothing has worked so far.

Rares Petru Samartean → created an issue.