🇧🇷Brazil @hmendes

I'm having a memory exhaustion problem with this patch together with the simple_sitemap → module, but I'm not sure on how to solve it...

Fatal error: Allowed memory size of 1073741824 bytes exhausted (tried to allocate 20480 bytes) in /var/www/html/web/core/lib/Drupal/Core/Render/Element/RenderElementBase.php on line 177

Looks like it's related to this change

-        $form['status']['#group'] = 'gin_actions';
+        $form['status']['#group'] = 'status';

Maybe bc simple_sitemap uses the $form['status'] for other stuff other then the publish option (ref)? Idk

It could "solve" the problem for by just updating the 'status name to smth else

 - $form['gin_sticky_actions']['status']
 + $form['gin_sticky_actions']['status2']

but I don't think that would be the best idea...

Idk if that's smth Gin should worry about, or smth to change on the sitemap_module, but I have no idea if there are other modules also using the $form['status'] for smth else, that could cause problems with this implementation... If you think that's not a problem for Gin, feel free to update the status back to Needs Review.

hmendes → created an issue.

hmendes → created an issue.

@saschaeggi, I'm also using DS and Gin and found this problem when saving the forms.
I just tested with the latest changes on the MR from 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review , I didn't test all the scenarios from that issue, so I don't wanna comment there stating that I did the tests, but for this problem with DS, it solved, thanks.

hmendes → created an issue.

Oh, ok, got it, thanks.
I fixed the issues related to phpcs/lint and phpunit, but I couldn't run the 'deploy' and 'test-running-environment.sh' scripts due to some issues in my local env, but I won't have time to fix it now, so if anyone wants to check it out, feel free to do so.

Created a config page for both messages.
I saw that there are a couple files related to phpunit and docker, honestly, idk if they're being used.. if my first time using this module and I've also being away from the community for a few months, so idk if smth changed and now those files are required...

Anyway, let me know if there smth else that should be changed, or if the code I changed impacted smth else bc of those extra configurations.

hmendes → made their first commit to this issue’s fork.

Creating a temporary solution for those who need it.
But further analysis of the problem is required to provide a proper solution.

hmendes → created an issue.

hmendes → made their first commit to this issue’s fork.

If anyone needs, that's the patch I'm using.

hmendes → created an issue.

hmendes → created an issue.

Hi, in my case the problem was in a custom code, so i didn't have to change anything on the module itself

Hello, just sharing my case here, it may help others:
I was also using this patch when I upgraded to drupal10. But I checked here and we had a custom code replacing SharethisManager with the service decorator, but in our constructor we didn't declare either the EntityTypeManager or the ModuleHandler (those parameters didn't exist in the previous version we were using), I just added both and it's working again, without the patch

hmendes → made their first commit to this issue’s fork.

Thank you!! 😊

Thanks

Fixed in the dev branch. Thanks

hmendes → created an issue.

hmendes → made their first commit to this issue’s fork.

I'm really sorry for the delay. Just created a new release for D10!
https://www.drupal.org/project/fontyourface/releases/4.0.0 →

Thanks for the patch :)

hmendes → created an issue.

Oh, ok. Now I understood the problem, it's not what I was thinking :(
I'm not too familiar with Layout Paragraphs, and I didn't know that u could add a paragraph with no fields and use it as the 'parent' paragraph. To explain the problem, gs_paragraphs module has 2 approaches to find the paragraphs:

Parent paragraph: searches in the HTML for that paragraph type, but only considers the paragraphs that doesn't have another paragraph as its parent.
Paragraph Field: basically does the opposite, only considers paragraphs within another one.

E.g:

It will consider as parent paragraph only the Section one, and will consider the Image as the child of Section.

The problem with Layout Paragraphs the way that you're using it is that, first, you can't use the "Paragraph Field" approach because it doesn't have any field, second, you won't be able to use the "Parent Paragraph" because if you have the Section paragraph, then the Image inside of it, it will consider that the image is a child of Section thus is not a parent paragraph.

I would have to think of a way to integrate these two module, but unfortunately I won't be able to do it now.
My suggestion: in your "Section" paragraph type, add a paragraph field for each paragraph type that u intend to add in your layout, then you'll be able to configure the animation for the fields. You can continue using the layout paragraphs the same way that you're using now, the difference is that you'll be able to configure the animations for each paragraph type that u put inside your Section.
For example, if you have the "text", "image", "cta" types that u can add to the layout, add 3 fields in your Section paragraph type, one for each of these types.

Thanks!

Hi, I created another issue to fix the problem related to the multi-value paragraph field, just in case there is actually a problem with the integration with the Layout Paragraphs module: 🐛 Animations doesn't work properly with multi-value paragraph field Fixed
If you want to, you can test the Merge request that I sent there, to see if it solves your problem.

hmendes → created an issue.

Hi ktegory,

While trying to reproduce your problem, I found one problem but it is not related to the "Layout paragraphs" module.
Steps:

• Create "A" paragraph with a text field.
• Create "B" paragraph with a multi-value paragraph field.
• Create a paragraph field in your content type.
• Configure the animations:
• Paragraph A: opacity 0 to 1
• Paragraph B. Only for fields, inherit from paragraph A
• Add a content with 1 paragraph A with multiple paragraph B.
• The animation only occurs once the first paragraph A disappears.

Can you confirm this is the problem you're facing?
For example, if you add a paragraph with Layout Paragraphs, but only add 1 inner paragraph in it, does it work?
If this is not your problem, can you provide the steps to reproduce it?

hmendes → created an issue.

I just changed the package on the dev version, once this issue is fixed I will update the module with a new release, thanks.
Thank you for the heads up about the git config, didn't noticed that before, it should be fine now.

hmendes → created an issue.

Thanks

Agree with the new name, and thanks for the fix on the doc block.
Uploaded a file to show the expected type of the return of entityTypeManager->getStorage().
Moving to RTBC.

hmendes → made their first commit to this issue’s fork.

Thanks!

Thanks for the fix.
Changing to RTBC

hmendes → made their first commit to this issue’s fork.

Thanks @paulocs.
Tested the code here locally and it worked for me. I did a simple implementation on a custom module setting the protection to TRUE on a specific form and it worked.

Tested with Drupal 9.5.1 and antibot 2.0.x-dev. Changing to RTBC.

It guess we could change this part

    $skip_antibot = FALSE;

    // Set skip antibot to true if user has appropriate permission.
    if ($this->user->hasPermission('skip antibot')) {
      $skip_antibot = TRUE;
    }

to

   $skip_antibot = $this->user->hasPermission('skip antibot');

But its not a required change, so I'll change to RTBC anyway.