[1.0.x] GreenSock Animations

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

FILE: gs.info.yml

package: Custom

FILE: modules/gs_paragraphs/gs_paragraphs.info.yml

package: Custom

Modules should avoid using that value for the package.

Please also check that Git on your computer has been set to use the same email used for your drupal.org account. Since they are different, your commits are not associated to your account.

Is there anything that needs to be changed?

Blocking an application asking to remove two lines in two .info.yml files when the code, for example, contains security issues or does not correctly use the Drupal API is not something that we should do. If the project would use a wrong branch name or it would include a license file that is not GPLv2, those would be additional reasons to change the status to Needs work.

I just changed the package on the dev version, once this issue is fixed I will update the module with a new release, thanks.
Thank you for the heads up about the git config, didn't noticed that before, it should be fine now.

No issues found
Changing status to RTBC!

• What follows is a quick review of the project; it doesn't mean to be complete
• For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

modules/gs_paragraphs/src/GsParagraphsHelper.php

$title = $type == 'Animation configurations' ?
      $this->t('@type', ['@type' => $type]) :
      $this->t('Values @type animation', ['@type' => lcfirst($type)]);

$this->t('@type', ['@type' => $type]) does not translate the content of $type. That code is exactly the same as the following one.

$title = $type == 'Animation configurations' ? $type : $this->t('Values @type animation', ['@type' => lcfirst($type)]);

The same holds true for the following lines.

          '#title' => $this->t('@title', ['@title' => $property_values['title']]),
          '#description' => $this->t('@description', ['@description' => $property_values['description']]),

Fixed in the dev branch. Thanks

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Thank you!! 😊

Automatically closed - issue fixed for 2 weeks with no activity.