๐Ÿ‡ฎ๐Ÿ‡ณIndia @bmahesh03121

Account created on 5 November 2020, about 4 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

There might be a possibility when custom implementation where we require the metadata attribute name in the event handler, i have added an extra argument for this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Rerolled the patch to update according to the latest changes in AssetUpdateChecker QueueWorker.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Hello @baluertl I have updated the issue description and proposed solution.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

still facing this error

Drupal 10.3.3

acquia_dam dev-1.1.x

while clicking on insert selected I am getting below error

"
An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /media-library?destination=/admin/content&ajax_form=1&_wrapper_format=drupal_ajax&complete_allowed_list%5B0%5D=acquia_dam_image_asset&complete_allowed_list%5B1%5D=image&media_library_opener_id=media_library.opener.field_widget&media_library_allowed_types%5B0%5D=image&media_library_selected_type=image&media_library_remaining=1&media_library_opener_parameters%5Bfield_widget_id%5D=field_media&media_library_opener_parameters%5Bentity_type_id%5D=node&media_library_opener_parameters%5Bbundle%5D=article&media_library_opener_parameters%5Bfield_name%5D=field_media&media_library_opener_parameters%5Bentity_id%5D=617501&media_library_opener_parameters%5Brevision_id%5D=1016592&hash=7MlUA2CT-96dB2Qd5iwPcfbIHwiZrWh9x_TphSzvWq4&source=core&views_display_id=widget
StatusText: Internal Server Error
ResponseText: The website encountered an unexpected error. Try again later.Error: Call to a member function getColumns() on bool in Drupal\Core\Entity\Query\Sql\Tables->addField() (line 246 of core/lib/Drupal/Core/Entity/Query/Sql/Tables.php). Drupal\Core\Entity\Query\Sql\Condition->compile(Object) (Line: 53)
Drupal\Core\Entity\Query\Sql\Condition->compile(Object) (Line: 177)
Drupal\Core\Entity\Query\Sql\Query->compile() (Line: 82)
Drupal\Core\Entity\Query\Sql\Query->execute() (Line: 147)
Drupal\acquia_dam\AssetRepository->find(Array) (Line: 111)
Drupal\acquia_dam\Plugin\views\field\MediaLibrarySelectForm->processInputValues(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('views_form_media_library_widget_image', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 224)
Drupal\Core\Form\FormBuilder->getForm(Object, Object, Array) (Line: 2265)
Drupal\views\Plugin\views\display\DisplayPluginBase->elementPreRender(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725' โ†’ , 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 870)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 504)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array) (Line: 475)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 49)
__TwigTemplate_1235ad64ad236fd727f341745b070f97->doDisplay(Array, Array) (Line: 360)
Twig\Template->yield(Array) (Line: 335)
Twig\Template->render(Array) (Line: 38)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('themes/contrib/seven/templates/classy/media-library/media-library-wrapper.html.twig', Array) (Line: 348)
Drupal\Core\Theme\ThemeManager->render('media_library_wrapper', Array) (Line: 491)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 231)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 68)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 270)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 137)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
"

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

any possibilities here, to provide crop to remote images via embed code

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Added the changes with reference from other ckeditor5 modules.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

I was still facing issues with this patch, and observed the console following error I looked at the following problems similar with other Ckeditor plugins

https://www.drupal.org/project/ckeditor_find/issues/3457140 โ†’
https://www.drupal.org/project/ckeditor5_template/issues/3456952 ๐Ÿ› Updating core to 10.3 breaks CKEditor Fixed

https://www.drupal.org/project/ckeditor_iframe/issues/3462027 ๐Ÿ› TypeError: t.Model is not a constructor (Drupal 10.3 compatability) Needs work

https://www.drupal.org/project/ckeditor_font/issues/3456088 ๐Ÿ› Incompatibilidad con Drupal 10.3.0 Postponed: needs info

https://www.drupal.org/project/ckeditor_templates_ui/issues/3457332 ๐Ÿ› Updating core to 10.3 breaks CKEditor Fixed

Added the changes with the fix

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

bmahesh03121 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

The module is tested thoroughly with the patch on Drupal 10 and a fresh Drupal 11 site.

The upgrade status shows no warnings.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

There is a different issue with MR ready for calls to kpr should not exist,

no other warning is found in the upgrade status except for .info.yml file changes which are fixed in this patch


moving this to RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

tested the given patch on Drupal 10.3.5,

it removes the upgrade status warning "Call to function kpr should not exist."

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Refined patch #11

Changes :

changed search_published_contents_only to search_published_content_only

changed Search published contents only to Search published content only

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

great work @skoro!

I was developing similar push notification functionality as well, my implementation looks very similar to this module,

i would like to actively participate in creating new feature requests, development and issue fixes for next few months

i will also suggest to create a slack group where people can connect for standardising this module as the base module for native push notifications functionalities

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

As push notifications are not part of the web page, we need to set the path alias(if exists) while registering the push notification.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121
  /**
   * Creates a block instance based on default settings.
   *
   * @param string $plugin_id
   *   The plugin ID of the block type for this block instance.
   * @param array $settings
   *   (optional) An associative array of settings for the block entity.
   *   Override the defaults by specifying the key and value in the array, for
   *   example:
   *   @code
   *     $this->drupalPlaceBlock('system_powered_by_block', array(
   *       'label' => t('Hello, world!'),
   *     ));
   *   @endcode
   *   The following defaults are provided:
   *   - label: Random string.
   *   - id: Random string.
   <del>*   - region: 'sidebar_first'.</del>
   *   - region: 'content'.
   *   - theme: The default theme.
   *   - visibility: Empty array (block will be visible on all pages).
   *
   * @return \Drupal\block\Entity\Block
   *   The block entity.
   *
   * @todo
   *   Add support for creating content block instances.
   */
  protected function placeBlock($plugin_id, array $settings = []) {
    $config = \Drupal::configFactory();
    $settings += [
      'plugin' => $plugin_id,
      'region' => 'content',
      'id' => $this->randomMachineName(8),
      'theme' => $config->get('system.theme')->get('default'),
      'label' => $this->randomMachineName(8),
      'visibility' => [],
      'weight' => 0,
    ];

@joachim looking at this, i found that the default value for region is

sidebar_first

, but in function definition its taking

content

as default region

+ will it be good idea to provide the example with few more settings like visibility, region, theme instead of just label.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

#11 tested and works fine, thanks joseph.olstad and gugalamaciek

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Any update on the Drupal 10 compatible version release?

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Any update on the Drupal 10 compatible version release?

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Any update on Drupal 10 compatible version release?

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Any update on Drupal 10 compatible version release ?

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

please check similar issue here https://www.drupal.org/project/drupal/issues/3378812#comment-15184658 ๐Ÿ› "Content language and translation" form doesn't save "Custom language settings" data Postponed: needs info keeping this in review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

apologies, let me clarify, after selecting or deselecting the elements at the top in 'Custom language settings', it will show or hide the details field translations settings. if you want to disable translations you can deselect the fields translations in below details section for particular element and can also set the default value for 'Default language' as the site's default language. after saving that it will not show the element as selected at the top 'Custom language settings'. i understand your issue now. that by changing the settings at the top, it should disable the whole translation. but I think the best way should be to review the fields and enable/disable the translations as required. instead of disabling the translations absolutely with non-recoverable translation loss issues. keeping this in review. please share your thoughts.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Works as expected, after selecting an entity type you must select at least add default translation and one field. otherwise it will behave as default settings and will save the configuration.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

changing the status, as this works as expected.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

Hello @Tanuj, this works as expected, actually with content language as 'sites default' and language alterable false, it is Default settings. and the form build checks if the configuration stored matches the default configuration then there is no need to keep this. if you make any changes to the default config other than (content_language: sites_default, language_alterable: false.) then it will save the settings.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bmahesh03121

bmahesh03121 โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024