- Issue created by @shani maurya
- 🇮🇳India shani maurya Mumbai
Is there any plan to make these elements align, frameborder, longdesc, and scrolling to be compatible with the ckEditor 5?
- 🇮🇳India shani maurya Mumbai
getting this error in console after enabling the deprecated attributes. PFA
- 🇮🇳India shani maurya Mumbai
I have created a patch. I made some modifications in the iframeEmbedFormView.js file.
The console error has been gone and align attributes are not coming in the iframe model.Require review and testing of this patch. As align feature is not working in my local due to my local CSS conflict.
- First commit to issue fork.
- Merge request !11#3462027: TypeError: t.Model is not a constructor (Drupal 10.3 compatability) → (Open) created by ericgsmith
- Status changed to Needs review
5 months ago 11:54pm 28 July 2024 - 🇳🇿New Zealand ericgsmith
Moved @Shani Maurya's patch to MR and relabeled the issue to clarify this is required for compatibility with Drupal 10.3. This change relates to a change in CKEditor 5 https://github.com/ckeditor/ckeditor5/issues/15661 - this module is no longer compatible with the version that ships with 10.3.x
That patch itself works for me on 10.3 - but I believe this will mean that it is no longer compatible with versions before 10.3
That either needs to be in the info file, or I can see other modules also impacted by this have added shims (e.g. https://git.drupalcode.org/project/ckeditor5_icons/-/blob/1.x/ckeditor5_... from 🐛 CKEditor 5 41.3.1 (Drupal 10.3 beta) breaking change Fixed
Leaving as needs review - hopefully a maintainer can provide guidance for the approach but for now the patch works to allow the plugin to be used with 10.3.
- Status changed to Needs work
5 months ago 5:12am 29 July 2024 - 🇳🇿New Zealand ericgsmith
Would also expect to see the ckeditor version bumped in the package.json and package lock files.
- 🇮🇳India shalini_jha
I recently upgraded to Drupal 10.3.1 and encountered the same issues with this module. I used the #6 patch, which resolved the issue.
Thanks