πŸ‡―πŸ‡΄Jordan @YazanMajadba

Account created on 9 September 2020, about 4 years ago
#

Merge Requests

More

Recent comments

πŸ‡―πŸ‡΄Jordan YazanMajadba

YazanMajadba β†’ made their first commit to this issue’s fork.

πŸ‡―πŸ‡΄Jordan YazanMajadba

@nicxvan Thanks for your feedback.

1-I removed the comments from the code.
2-I created a test method.

πŸ‡―πŸ‡΄Jordan YazanMajadba

Drupal 10.1.6
PHP 8.1

πŸ‡―πŸ‡΄Jordan YazanMajadba

Hi @gausarts

I updated the module to last version and the above patches not working
are there plans to reroll the patch?

πŸ‡―πŸ‡΄Jordan YazanMajadba

Comment #7 it's working with Drupal 8
but when I upgraded to Drupal 10 I got this error:

Error: Call to undefined function Drupal\video_embed_field\Plugin\Field\FieldFormatter\file_create_url() in Drupal\video_embed_field\Plugin\Field\FieldFormatter\ThumbnailURL->viewElements() (line 85 of modules/contrib/video_embed_field/src/Plugin/Field/FieldFormatter/ThumbnailURL.php).

I Fixed the deprecated function

file_create_url($uri) \Drupal::service('file_url_generator')->generateAbsoluteString($uri)
file_url_transform_relative($file_url) \Drupal::service('file_url_generator')->transformRelative($file_url)
file_url_transform_relative(file_create_url($uri) \Drupal::service('file_url_generator')->generateString($uri)
Drupal\Core\Url::fromUri(file_create_url($uri)) \Drupal::service('file_url_generator')->generate($uri)

πŸ‡―πŸ‡΄Jordan YazanMajadba

Yes now we can include the title with URL

Production build 0.71.5 2024