- last update
8 months ago 50 pass - Issue created by @YazanMajadba
- Status changed to Postponed: needs info
8 months ago 2:46pm 30 October 2023 - 🇮🇩Indonesia gausarts
Thank you.
May I know your Drupal version?
> now the isAmp function returns a false because the amp query is an empty string, not a null
Hmm, I don't quite understand :)I might miss the point, but with or without your patch, PHP would return the same thing, would not it?
- 🇮🇩Indonesia gausarts
> PHP 8.1
Makes sense. I noticed one or two changes I made myself with some conditions when upgrading to PHP8.1 last time.Please allow some delay to get back to it.
-
gausarts →
committed 6d7ad5f8 on 8.x-2.x authored by
YazanMajadba →
Issue #3397716 by YazanMajadba: Images not loaded on AMP pages
-
gausarts →
committed 6d7ad5f8 on 8.x-2.x authored by
YazanMajadba →
- Status changed to Fixed
8 months ago 3:01am 4 November 2023 - 🇮🇩Indonesia gausarts
Committed. Thank you for contribution and patience.
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.