RTBC!
I've decided to close my merge request for this task, because once we tested the rerolled patch we discovered that it only supplies the newest translation suggestion per node, regardless of how many translations there are of that node, as wim leers → mentions as a potential issue in comment #63 ✨ Multilingual support: Allow linking to specific translations Needs review , above. Our client's site has 15+ potential translations per node, so this solution won't work for our specific scenario.
We solved the issue with elgandoz → 's new commit of this issue ✨ Allow user to link to a page in a different language Active , which worked when applied to the 6.1.6 branch.
If I were going to put in more work on this problem, I'd put it towards Allow user to link to a page in a different language ✨ Allow user to link to a page in a different language Active .
This solution worked well for our team; we used elgandoz → 's new commit against 6.1.6.
RTBC!
ji_gravityworks → made their first commit to this issue’s fork.
ji_gravityworks → made their first commit to this issue’s fork.
JI_Gravityworks → created an issue.
@seanb -- Here's the new branch with the subgroup support removed:
https://git.drupalcode.org/issue/groupmenu-3351701/-/blob/groupmenu-3351...
And the new MR:
https://git.drupalcode.org/project/groupmenu/-/merge_requests/10
Thanks for your help!
@SeanB -- I have rolled both these changes into this release:
#3305893: Fix the issues reported by phpcs
#3308654: Drupal 10 compatibility issues
I suppose you could approve them individually and then I can pull them in one at a time and fix any conflicts. Let me know if you would like to go in that direction. Otherwise, tomorrow at Drupal MidCamp I'm going to spend some time in the contribution room and separate the Subgroup functionality into its own MR. Thanks for taking the time to review my code!
@Bushra-- I think the patch at #6 works; we're working on adding a bit more functionality in #7. Could you give that one a try? Thanks!
JI_Gravityworks → created an issue.
Hello! We are definitely going to need this for one of our clients, so I'm following this thread. I'll be using 3.0.x and will provide feedback as I go.
Thanks for taking the initiative on this!
Hello! I've just submitted a code package on this issue 📌 Automated Drupal 10 compatibility fixes Needs review that upgrades Group Webform to use Groups 3.0, Drupal 10, and Webform 6.2. If you have a chance to help review the code, we can get it available to the public sooner. Thanks!
Hello! I've just submitted a code package on this issue 📌 Automated Drupal 10 compatibility fixes Needs review that upgrades Group Webform to use Groups 3.0, Drupal 10, and Webform 6.2. If you have a chance to help review the code, we can get it available to the public sooner. Thanks!
Hello! My company has a client that needs this module upgraded to use Drupal 10 and Groups 3.0. I've just committed a working version and would love feedback on it. I chose to commit it on this branch so that others would get proper credit for their D10 readiness updates. I also included the patch at https://www.drupal.org/project/group_webform/issues/3321229 📌 Replace README.txt with README.md RTBC since it was RTBC, though I made some text additions to the README.md file.
Fork branch is here:
https://git.drupalcode.org/issue/group_webform-3287825/-/tree/group_webf...
Comparison is here:
https://git.drupalcode.org/issue/group_webform-3287825/-/compare/8.x-1.x...
MR is here:
https://git.drupalcode.org/project/group_webform/-/merge_requests/6
Thanks to @tonibarbera, @SocialNicheGuru, @stephen-cox, @Anmol_Specbee, @Sonal Gyanani, and @gowthamrajkrishnasamy for your contributions!
JI_Gravityworks → made their first commit to this issue’s fork.
I did some fairly thorough testing, and now have a release candidate for D10/G3.0, with Subgroup module support.
@ao5357 thank you for such a strong starting point.
@msielski this fixes the string/integer menu id issue and requires no further patching.
@ericras feel free to review.
@chuyenlv, @Adarshsri786, @dasginganinja thanks for the patch code at https://www.drupal.org/project/groupmenu/issues/3308654 📌 Drupal 10 compatibility issues Needs review
@ericras I'm getting a stable version ready. I'm using the work of many other contributors and want to make sure I've got everything working, documented, and all attributions listed so that everyone will get proper credit. It may be a while longer but I'm definitely planning on at least submitting it for RTBC.
Duplicate of https://www.drupal.org/project/subgroup/issues/3374197 💬 How do I create a subgroup? Fixed
JI_Gravityworks → created an issue.
Thanks for the suggestion, but Group Content Menu will not serve our purposes.
I downloaded the module, made some updates, and am currently using it with Groups v3 and D10 as though it were a custom module. It seems to be working fine. Since the work is done, I'm not certain if others would want a new branch if I uploaded the code.
@msielski -- Thanks for the tip! We gave that a try already, but Group Menu is much closer to the functionality we need. Let me know if there's anything I can do to affirm this code so we can start a new version.
Our team is very interested in this module for use with one of our current clients. Their site is on D10 and I can't install this fork or its patch due to the version constraints on the 8.x-1.x-dev version.
@ao5357
Would it be possible to create a new 2.x version branch? Is there anything we can do on our side to help that process along? We'd definitely be testing it a lot in the near future and can provide feedback as needed. Thanks!
I'm also seeing this issue with the newest/dev version of 6.0. Is there a fix for it?