Hi, attaching a working patch for this. Thanks to @star-szr for the help!
saurabh-2k17 → created an issue.
Apologies @jurgenhaas, I will keep MR thing in mind. I see what you did and tested it too, it works! I am changing the state to RTBC.
I found that the problem was not with the content, the content was already there, just that it was expecting it to be in a readable format. I made a slight change and it works now.
Hi @jurgenhaas, thanks for your response and MR. I updated the Drupal core to 10.1.7 and tried to visit https://sitenme.org/jsonapi/ and faced the similar issue. Later, I used your MR and patched the module but the same problem persists.
Hi @DieterHolvoet thanks for your quick response! Much Appreciated
After applying the patch, I referred to the comment on #10. As per that, I should not see the Back to site link after logging in as Administrator and visiting the content listing page or similar, but I could see it. The only time I was not seeing the link was, when I was visiting a 403 page (without logging).
Hi, I tried to use the diff, but it is not working. Changing the status back to Needs Work.
Correction in patch name and line number of code.
Hi, I have updated the patch as per the new releases. In the module I have created a new test case as the input accepted by both created and changed fields accepts only TimeStamp values.
I am trying to make the above patch compatible with the latest version, but it is breaking at multiple steps. Anyone tried the above patch on recent versions?
I have committed the changes suggested by Upgrade Status module. Few namespaces which were added by the bot were not added as they were never suggested by upgrade status.
I have updated the patch for the latest version. Make sure after applying the patch, reinstall the module for this feature to work.
I have marked the issue as critical because I see there are two older issues with the similar problem.
https://www.drupal.org/project/taxonomy_import/issues/3238608 →
https://www.drupal.org/project/taxonomy_import/issues/3225261 →
saurabh-2k17 → created an issue.
@bsufan17 @jeppy64
What did you do to import the created date (Authored on)? Also, for future reference, it's always better to share how you did it.
Hi, I updated the patch with some changes.
Apologies for the wrong naming
I am attaching a working patch here.
Hey @jurgenhaas @muriqui thanks for working on this issue. I am experiencing the same thing and followed the earlier threads to reach here.
Sadly, even after using the above changes, I am getting the same error.
TypeError: Cannot assign null to property Drupal\eca\Entity\Eca::$id of type string in Drupal\Core\Entity\EntityBase->createDuplicate() (line 358 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityBase.php)
I am using 2.0.0-beta3 version of the module.
Any ideas what could be the issue? TIA
Are we still experiencing this with the 4.x?
Thank you everyone for your effors.
I noticed that the patch is not applying on 4.x branch, moving this to need work. I will create a new patch compatible with that branch and will commit that.
Thank you everyone for your support.
Thank you everyone for your efforts.
Thank you everyone for your efforts.
Thank you everyone for your efforts.
Thank you everyone for your efforts on this.
I noticed that the change in ConditionalFieldsFormHelper.php is not affecting when we are using a reference field in a content type and that reference field has a hidden field which is required.
Example, for Basic content type, I have a reference taxonomy field. That taxonomy field has a bool field which displays a required text field. Even after making the above change, that hidden text field is still being required while adding a content.
I am attaching a working patch for this issue.
Hey, I am experiencing the same issue on my local and the above patch is fixing it.
Hi @Summit, Apologies for the delay.
- So two times postal code, is that correct?
No, absolutely not, I have updated the patch and added an interdiff.
- Aha...langcode is already taken care for, and does not need to get from the address you explain?
Where is the field to store language in address field type? Do you see it?
- And how to add this into the csv please? Just as a line of fields?
You can download the sample csv file for your content type by visiting /admin/config/content/contentimport, once done you will find your address field too inside it. In my case its
title,langcode,status,promote,body,field_address,...........
Test Event,en,on,,Events Body,CA|Consensus|given_name|family_name|ABC Pintail Cr|North York|Toronto|ON|M3A 2Y7,.........
you can put any random value or keep it blank if you have not enabled that field from the content type field settings. Like in my case I dont have "given_name" or "family_name" enabled.
Hi, I am facing the same issue and came across this thread. I see there is also a dependency by Drupal core 🐛 HTML5 validation is preventing form submit and not fully accessible Needs work
I applied #3 patch from here along with other patch from the Drupal core issue, but this is not working.
Furthermore, I am also on Drupal core 9.5 and alpha2 version of module. I am curious to know what was the last Drupal core version for which this was working?
So the actual issue is with the Drupal core, no changes required in the above patch as it works fine. Not every patch is going to work from here - https://www.drupal.org/project/drupal/issues/1149078 🐛 States API doesn't work with multiple select fields Needs review , in my case #142 worked.
Hey, I am using 4.0.0-alpha2, I applied the Drupal core patch along with these two one by one, but sadly it is not working in my case.
@abarrio what version did you use when you last applied this patch?
Any ideas why this is not working?
Hey @Summit
Thanks for looking at the patch.
- In the patch is twice the 'postal_code' => $address[6] ?? '', and 'locality' => $address[6] ??
Please refer patch #12
I am unsure why to do this, kindly explain.
'locality' => $address[7]?? '',
'administrative_area' => $address[8] ?? '',
Are you sure this should go in the case 'address':
'langcode' => 'en',
There is a case 'langcode': here
@mherchel thanks for this patch, I am facing similar problem. On page load, the "Target field" (Text field) is not being shown even if the "Controlled By" field (Select List) value is set to show the "Target field" but once I change the value of the select list field it removes the style="display: none;" attribute, which displays the hidden field.
Sadly, the patch is not covering the aspect which I am mentioning.
I found that the above patch does not add the * sign on the top of the field to display as it a required field. This patch will fix that issue as well.
The above patch was not getting applied as it was not created correctly. Also, there are some changes in the latest 4.0.0-alpha2 version of the module.
I have attached a working patch.
Thanks
saurabh-2k17 → created an issue.
Added the README file.
Thanks
saurabh-2k17 → created an issue.
Apologies for not adding the interdiff.
Thanks
I noticed after using the module for some time that "administrative_area" field in the address was missed. Adding the updated patch with this field.
Thanks
Thanks @benkallos, for the patch. I have now ported it with the latest version of the module, using the same concept I have added the link field which can be now imported easily. The URI and Title will be added in the CSV using this format https://www.google.com|Google
.
I was facing the same issue for 8.9.x branch, so I have back ported #213 patch and made it compatible.
PFB patch for 8.9.x branch.