Do not hijack existing routes

Created on 12 December 2022, over 2 years ago
Updated 13 October 2023, over 1 year ago

Problem/Motivation

This is a follow-up on 🐛 Add a way to exclude certain entity types from cloning Fixed where I commented in #16 🐛 Add a way to exclude certain entity types from cloning Fixed that this module should not hijack existing clone routes.

Proposed resolution

Check, if a route exists before overwriting it.

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India saurabh-2k17

    Hey @jurgenhaas @muriqui thanks for working on this issue. I am experiencing the same thing and followed the earlier threads to reach here.

    Sadly, even after using the above changes, I am getting the same error.
    TypeError: Cannot assign null to property Drupal\eca\Entity\Eca::$id of type string in Drupal\Core\Entity\EntityBase->createDuplicate() (line 358 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityBase.php)

    I am using 2.0.0-beta3 version of the module.

    Any ideas what could be the issue? TIA

  • 🇩🇪Germany jurgenhaas Gottmadingen

    @muriqui thanks for the modification, and sorry for my late response as I missed this issue's notifications somehow. This looks good to go, I just wonder why this is now for the 1.x branch and not for 2.x anymore?

    @saurabh-2k17 it's hard to dig into the code with the given amount of information. Can you please explain in more detail, what components you're using, how you got to the error message and then please provide the full stack trace?

Production build 0.71.5 2024