Reviewed and tested!
Merged into 1.x and moving to RTBC.
Tested on existent site.
Moving to RTBC.
Thanks @crzdev
Thanks @pdureau for your interest and feedback.
We'll start working on this probably next week :)
@Bryan I think is a good idea to keep both selectors for compatibility. I've updated the merge request
alejandro cabarcos β made their first commit to this issueβs fork.
Reviewed on existent projects. It works as expected.
Once released we should highlight that permissons update might be needed on the release notes.
Moving to RTBC!
alejandro cabarcos β created an issue.
Reviewed & merged into 1.x
Reviewed & tested.
Merged into 1.x
RTBC, merged into 1.x.
Moving to fixed.
Thanks Simon and Sylvain for your efforts!
Reviewed and tested. Merged on 1.x
alejandro cabarcos β created an issue.
alejandro cabarcos β changed the visibility of the branch 3475532-remove-jquery-dependency to active.
alejandro cabarcos β changed the visibility of the branch 3475532-remove-jquery-dependency to hidden.
alejandro cabarcos β created an issue.
LGTM, I have added a message for blocks that are not InlineBlock so the user is aware that he should add it manually.
Alejandro Cabarcos β made their first commit to this issueβs fork.
Tested between Drupal 10.2.x, working good.
Moving to RTBC.
frouco β credited Alejandro Cabarcos β .
frouco β credited Alejandro Cabarcos β .
+1, moving to RTBC
For me its working as expected, moving to RTBC.
MR looks good
Alejandro Cabarcos β created an issue.
Opened a MR with the changes suggested from #7
Alejandro Cabarcos β made their first commit to this issueβs fork.
LGTM!
Im not sure how we should handle the patches dependency. After reading composer docs and checking other contrib modules, the suggest composer property is used to suggest packages that can improve/boost/help this package.
https://getcomposer.org/doc/04-schema.md#suggest
For example, we could use this property to recommend the Ajax Loader β module, but in this case, we need these patches to be applied.
I think we should provide help so those issues are fixed, and until then, create forks for these modules with the patches applied.
What do you think?
Alejandro Cabarcos β made their first commit to this issueβs fork.
Reviewed.
Tested aswell with bundle fields and its working.
LGTM!
Alejandro Cabarcos β created an issue.