Created a MR for the issue. I needed to make the style !important, unfortunately.
Tested the patch on an installation and it works fine! Patch looks also good.
I am experiencing the same error. The provided snippet fixes it for me.
just another observation: this is a regression, it worked before.
stmh → created an issue.
seems to be a javascript error:
stmh → created an issue.
hi, MR4 works for me as well!
thanks for the patch, but unfortunately it is not working on my end.
Thanks for moving this forward. One objection on only showing the leaf term is that in my particular use-case I have some leaf terms with the same name, but with different parents. Then they are hard to differentiate. Maybe we can make it configurable/ overridable?
that is also my use case. It reduces complexity in my modules, because all initial translations are in one file.
This is also happening for us, and we are not using the layout_builder_admin_theme.
There is currently no way to modify the interface language similar to what you can do with overriding the config language.
Think of a twig template for rendering content (of a specific content language) for e.g. a PDF (which has some static, translated interface-strings in it using the t-filter), and you want to use a different language from the current interface language. E.g. my interface language is en, but the content is de, and I want the rendered PDF in interface language de.
I'd update the tests, as the benefits are bigger than the downsides. it removed 30k requests/min from our customer project. Augmenting the class with another class doing the cache seems like bloat to me. It's not a public property, there are getters and setters, so the class is in full control over its implementation, so you can handle all side cases inside the class.
see attached MR
Worked on #92 and #93, see my latest commits.
stmh → changed the visibility of the branch advancedqueue-2918866-2918866-add-support-for to hidden.
@joachim Oh yes, let's do this. I had my problems understanding them as well.
Regarding your comments:
I think its safe to remove the comment, as enqueueJob and enqueueJobs will throw an exception if you try to add a JobItem that needs uniqueness and the queue does not support it.
Regarding the second comment. The Queue itself provides two function enqueueJob and enqueueJobs to add jobs, which looks fine to me.
I reviewed the code and have no objections in merging it back. I also tested the new functionality in a project where I need the functionality and it works flawlessly.
Mark as RTBC
Change is looking good, I think this is RTBC
sanduhrs → credited stmh → .
sanduhrs → credited stmh → .
sanduhrs → credited stmh → .
sanduhrs → credited stmh → .
I cant find the changes in 1.0.17 or newer. Also the MR is still open.
I discovered another small bug (partial exception message) which I fixed in this MR. Ready to be reviewed.
Created MR with fix.
Patch reviewed and tested on my end; it works fine. Thanks!
Hi, we are using the patch from #120 and it introduces a lot of problems when you have more than one PHP workers, as the function is not atomic anymore. This might work in a single-threaded install but will fail with hard to debug concurrency issues when called by code on every request. The purge module for example tries to create a table if it does not exist prior which leads to a never ending series of table creation and -dropping as one function call form Worker A is intertwined with a function call from Worker B.
This happens under heavy load only, but still the offending code should be guarded by a lock.
As the offending styles can also be found in backend-form.css I removed the styles from the iframe.css. Please review.
Provided a patch via MR. Please review.
stmh → created an issue.
The patch from #14 works as advertised, but not 100% correct, at least for my scenario. Say I have 2 languages en and de. I create content in en and add a translation for de. Editing the translation works as expected, but the preview shows then the english page. Reloading the page shows then the updated content in the correct language.
thanks for the patches. Will do some tests before creating a new release.
insteds of an alter hook you can inject it via the preprocess hook. So no changes needed to layout_paragraphs
/**
* Implements hook_preprocess_layout_paragraphs_builder().
*/
function layout_paragraphs_iframe_modal_preprocess_layout_paragraphs_builder_controls(array &$variables) {
foreach ($variables['controls'] as $ndx => $control) {
if (!empty($control['#attributes']['data-dialog-type'])) {
$variables['controls'][$ndx]['#attributes']['data-dialog-type'] = 'iframe';
}
}
}
Here's some testing feedback: At least when using gin, the field shrinks in size when deleting the existing content and increases in size while typing. As the input width defines the width of the autocomplete, it is hard to select people.
See attached video:
https://www.drupal.org/files/issues/2023-01-28/CleanShot%202023-01-28%20... →
next meeting: Feb 9th, 16:00 -17:00 most likely here: https://meet.drupal.de/drupal-ev
We use drupals slack to coordinate, feel free to join #drupal-de-relaunch
baddysonja → credited stmh → .