🇫🇷France @klelostec

klelostec → changed the visibility of the branch 2.x to hidden.

klelostec → created an issue.

klelostec → created an issue.

Hello,

This error occured because of update API. Update module do HTTP requests to url https://updates.drupal.org/release-history/drupal/current which responds "No release history was found for the requested project (drupal)." instead of the releases list.

It works for contrib modules ! Just core has an impact.

klelostec → created an issue.

klelostec → created an issue.

klelostec → created an issue.

klelostec → created an issue.

klelostec → created an issue.

klelostec → created an issue.

klelostec → created an issue.

Hi Striknin,

Thanks for the issue.
The actual submodule is only compatible with ^1.6 version of google_tag module (see composer.json in submodule).
The tricky part is that composer doesn't take care of submodules composer requirements.

In my opinion, the tarte_au_citron_googletagmanager submodule should be deprecated and a dedicated new module should be created.

Could you help to create a version compatible with 2.x version of google_tag ?

#149 patch works for me with state visible but doesn't work with state empty.
I set conditional fields on a paragraph and both "target" and "controlled by" fields are located in the same paragraph bundle.
Paragraph are added with a field Entity reference revisions (Reference type: Paragraphe)

In the javascript file conditional_fields.js, "state:empty" bind function has a condition on e.effect value to emptying input.
In my case e.effect is always undefined so the target field is not emptying.

I think this is because of JS settings because when I observe drupalSettings.conditionalFields.effects, it doesn't contain a key with the id of my "controlled by" field.

klelostec → created an issue.

I reproduce the issue only with the tabs component (in /formatters/fieldset/tabs.js).
The code in 8.X-3.x branch seems good, and use once in the right way according to Drupal 10.
I made a patch to fix the 8.x-3.4 version.

klelostec → made their first commit to this issue’s fork.

klelostec → made their first commit to this issue’s fork.

Hello @prudloff
Thanks for your proposal.
At this time, I freeze the implementation of new services support. The reason is there is a lot of tarte au citron services and to make easier this module management I plan to move submodules outside this one.
This way, we'll be able to manage services module releases indenpendently from this one like jquery_ui module does.
And the most important reason is to manage compatibilities with other contrib module versions. For example, at this time tarte_au_citron_googletagmanager is only compatible with google_tag version 1.6 while a 2.x version is available.

It will be very helpful if you create the module for the wanted services and I will be very happy to reference them here.

Thanks a lot @prudloff.

I fixed this using the Xss::filterAdmin() solution which seems better to me.
This one prevents a malicious user from being able to exploit the XSS vulnerability if he is able to login with a user assigned to roles which are granted to the permission.

klelostec → made their first commit to this issue’s fork.

Thanks @apaderno.

You've linked on old issue which has been created by another member of my team.
Did you wait some actions on me side or we still wait for other reviewers to check the module ?

Many thanks for the interest and your time for this issue..

I disagree with the quote below

Trivial non satisfying (IMHO) solution: rename the argument. Better solution: support it, pretty much like route matches are supported based on class instead of name using the @argument_resolver.route_match service

In my opinion, because of the impact on core/others modules,

the work around with the argument resolver component is too risky compare to just renaming the variable $formState -> $form_state in the buildForm methods of mongodb_watchdog forms.

When I encounter the issue, It was hard to understand and found the origin.

But thanks, I learn a new

I do my best to understand why the component FormStateValueResolver has been used and the issue 3006502 🐛 Core should not rely on $form_state name Needs work helps me a lot.

I disagree with the note https://www.drupal.org/project/mongodb/issues/3005108#comment-12813643 → and consider the problem should be fixed in core, not in a contrib module but i respect the decision to implements the fix here, so the MR fix the issue and add 2 test cases in this way.

I change the version from alpha1 to alpha2 because I'm currently having the problem with the alpha2 version.
I check the git to understand when the component FormStateValueResolver was added and it was on alpha1 that's why I've reported this version.
I did some additional tests and I can reproduce the issue on alpha1, alpha2 and 2.x-dev versions.

About writing a test case with PHPUnit, I don't know how to do it for this tricky problem, but I'll give it a try and complete this issue when done.

klelostec → created an issue.

Hello @S3b0uN3t

Thanks for your patch.
Unfortunally, this patch only provides a library which is not sufficient to implements this functionnality.

Morever, the submodule "Tarte au citron Media Remote Videos" works with the media core module. This one provide only 2 remote video providers out of the box : Vimeo and Youtube (please see the OEmbed deriver).

In a future version of this module, the submodules will be deprecated and replaced by other modules to make easy the maintenability and compatibility with other contrib modules.

In order to provide this functionnality, I recommand to create a new dedicated module to do this.

Thanks @vishal.kadam, I've fixed the files.

klelostec → created an issue.

klelostec → made their first commit to this issue’s fork.

Hello @Jitendra_Kumar

Thanks a lot for your contribution.

Your MR contains more than just a fix for the hook_help and add a new submodule with tarte au citron plugin.

To keep this module simple and maintenability, submodules which implements new tarte au citron plugins should be a new contributed module with a dependency to this one.
Futurely, I plan to deprecate current submodules and provide separated modules for each ones. This will prevent to create a new release for submodules changes.

About the hook_help for the main module, I add one with a link to the main Tarte au citron settings pages.

klelostec → made their first commit to this issue’s fork.

klelostec → made their first commit to this issue’s fork.

Patch #4 works for me with version 2.3.

This solves my problem with CSS aggregation enabled.
In this case, Drupal tries to download CSS file from a public URL which timeout due to the network server configuration.
This causes very long page loads after cache clear.

Rerolling patch to work with 6.0.1 release.