- Issue created by @klelostec
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- 🇮🇳India vishal.kadam Mumbai
1. FILE: tarte_au_citron.info.yml
FILE: modules/tarte_au_citron_xiti/tarte_au_citron_xiti.info.yml
FILE: modules/tarte_au_citron_smarttag/tarte_au_citron_smarttag.info.yml
FILE: modules/tarte_au_citron_recaptcha/tarte_au_citron_recaptcha.info.yml
FILE: modules/tarte_au_citron_media_remote_video/tarte_au_citron_media_remote_video.info.yml
FILE: modules/tarte_au_citron_gtag/tarte_au_citron_gtag.info.yml
FILE: modules/tarte_au_citron_googletagmanager/tarte_au_citron_googletagmanager.info.yml
FILE: modules/tarte_au_citron_addtoany/tarte_au_citron_addtoany.info.ymlcore: 8.x
The core: key must not be used here to make sure that versions of Drupal before 8.7.7 will not install the module. Adding both core and core_version_requirement with anything other than core_version_requirement: ^8 || ^9 || ^10 will result in an exception.
2. FILE: src/Form/ConfigurationForm.php
/** * The editable config name. */ protected function getEditableConfigNames() {
{@inheritdoc} comment is used if you are overriding or implementing a method from a base class or interface.
- Status changed to Needs work
over 1 year ago 8:50am 23 May 2023 - Status changed to Needs review
over 1 year ago 9:00am 23 May 2023 - 🇮🇳India vishal.kadam Mumbai
Rest looks fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
- 🇫🇷France klelostec
Thanks @apaderno.
You've linked on old issue which has been created by another member of my team.
Did you wait some actions on me side or we still wait for other reviewers to check the module ?Many thanks for the interest and your time for this issue..
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
- Dries → ' post on Responsible maintainers
- Best practices for creating and maintaining projects →
- Maintaining a drupal.org project with Git →
- Commit messages - providing history and credit →
- Release naming conventions → .
- Helping maintainers in the issue queues →
You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.I thank all the reviewers.
- Assigned to apaderno
- Status changed to Fixed
over 1 year ago 4:49pm 4 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.