PHP Fatal error due to FormStateValueResolver

Thanks for the report, it seems already fairly detailed: are you able to write a test case failing (or even crashing) because of this error ?

Downgrading because it doesn't prevent use of the module.

Also, you reported this on alpha1, but the most current release has been alpha2 since 08/2022: is it just an issue error, or is the issue really on alpha1 ? If that is the case, can you reproduce it on alpha2 or dev HEAD ?

I change the version from alpha1 to alpha2 because I'm currently having the problem with the alpha2 version.
I check the git to understand when the component FormStateValueResolver was added and it was on alpha1 that's why I've reported this version.
I did some additional tests and I can reproduce the issue on alpha1, alpha2 and 2.x-dev versions.

About writing a test case with PHPUnit, I don't know how to do it for this tricky problem, but I'll give it a try and complete this issue when done.

I do my best to understand why the component FormStateValueResolver has been used and the issue 3006502 🐛 Core should not rely on $form_state name Needs work helps me a lot.

I disagree with the note https://www.drupal.org/project/mongodb/issues/3005108#comment-12813643 → and consider the problem should be fixed in core, not in a contrib module but i respect the decision to implements the fix here, so the MR fix the issue and add 2 test cases in this way.

Thanks, I'll look into it when I have some time (it's hectic these days).

Not sure why you say you disagree with my comment ? My point is (a) this is due to core relying on the param name (hence 🐛 Core should not rely on $form_state name Needs work ) but (b) core won't move for years (that core issue is already 3.5 years old), hence (c) work around the issue in our contrib module. Which part(s) do you disagree with ?

I disagree with the quote below

Trivial non satisfying (IMHO) solution: rename the argument. Better solution: support it, pretty much like route matches are supported based on class instead of name using the @argument_resolver.route_match service

In my opinion, because of the impact on core/others modules,

the work around with the argument resolver component is too risky compare to just renaming the variable $formState -> $form_state in the buildForm methods of mongodb_watchdog forms.

When I encounter the issue, It was hard to understand and found the origin.

But thanks, I learn a new

Thanks for clarifying your PoV. I do not share it, but it does make sense.

This being said, your fix looks good to me, thanks.

Merged to current HEAD, thanks.

Automatically closed - issue fixed for 2 weeks with no activity.