🇮🇳India @pratik_kamble

stovak → credited pratik_kamble → .

brianperry → credited pratik_kamble → .

While testing on the Postman, I had to fetch the x-csrf-token from path `session/token`. Get the cookie value from the browser.
Do we expect to perform the operation to fetch x-csrf-token. and session value by calling `user/login` path with appropriate params in the code?

@brianperry I did not understand what is the meaning of "Skip Index Lookup For Default Resource Types". Can you help understand it with example.

@brianperry @CobyPear For cookie based authentication what should be parameter for object?

{type: "Cookie", credentials: {xCSRFToken: "token", value: "cookiesessionstring"}

pratik_kamble → created an issue.

@brianperry What should be response if the both `rawreponse` and `all` flag is true.

Do we need option disable authentication for methods like Patch, Post, Delete? By default Drupal will require some authentication for these methods. Can you help understand what is expected out of this issue.

@brianperry, Are you talking here about JSONAPI Client method?

@brianperry I did not fully understand what is expected output here? Do we want to disable pagination? Because as far as I know we can't get disable pagination for JSONAPI client.

@coby.sher Make sense to me. Considering 5XX will be treated as normal response only.

pratik_kamble → created an issue.

@brianperry we have already upgraded to 2.X version. We can close this issue.

pratik_kamble → made their first commit to this issue’s fork.

Rebased PR. Moving it back to needs review.

Apologies for the late action. Merged patch. New release is available here: https://www.drupal.org/project/views_complex_grouping/releases/8.x-1.0-b... →

@shrutishende LGTM. But we are planning to merge other PR first so you will have to do rebase.

@coby.sher I have tried to add the base64 encoded query params to cache key. Though it work. I just feel cache key will be too long based on the query params so reverted it.

BTW PR is ready for review.

@coby.sher Are we expecting raw response to be cached? If yes then I think we should have different key it. Let me know what do you think.

When running locally, if the 'debug' option is set to true, the code adds debug messages using the default logger. To view these messages, you can adjust the default log level in your Chrome settings.

Alternatively, if you provide a custom logger, the code will use that custom logger instead."

pratik_kamble → made their first commit to this issue’s fork.

@brianperry @CobyPear, just wondering how cache should work with api parameter. Should we add query param(by doing base64 encoding) in the cache key?

May be for future PRs. I was wondering what is best way to showcase this examples? Should we create another page in examples? @brianperry would love to hear your thought on it.

Retested MR on my local environment and verified that it utilizes the cache from local storage once the cache option is passed to client.

@brianperry Can you confirm the outcome for this issue is to allow adding query parameter(filter) while retrieving content? If true then we should implement it like below
- get method will have additional parameter filter get(type: string, filter?: [string, any][])
- use received filter to prepare the query parameter.

I've tested the MR on my local environment and verified that it utilizes the cache from local storage once the cache option is passed to client.