- Issue created by @coby.sher
- Assigned to abhisekmazumdar
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:01pm 8 October 2023 - 🇮🇳India abhisekmazumdar India
Looking for feedback also I will need some inputs for the test case.
Will the Mocks file for this will be txt file or json file is only required.
- Status changed to Needs work
about 1 year ago 1:07pm 8 October 2023 - 🇮🇳India pratik_kamble Pune, India
@coby.sher Are we expecting raw response to be cached? If yes then I think we should have different key it. Let me know what do you think.
@pratik_kamble I dont think it should be cached in this case. There is a use case for needing to read the headers from the response in addition to the json from Drupal. I don't think we'll want to cache the response in this case but I could be convinced otherwise.
This might highlight desire for a a per-request opt-out for the cache.
- Assigned to shrutishende
- Status changed to Active
about 1 year ago 3:29pm 12 October 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:31pm 14 October 2023 - Status changed to RTBC
about 1 year ago 7:33pm 14 October 2023 - Status changed to Needs review
about 1 year ago 4:53pm 1 November 2023 - 🇮🇳India pratik_kamble Pune, India
Rebased PR. Moving it back to needs review.
- Status changed to RTBC
about 1 year ago 5:25pm 1 November 2023 - Status changed to Needs work
about 1 year ago 2:54pm 4 November 2023 - 🇺🇸United States brianperry
Setting this back to needs work. I still think we need to come to a final decision about what the changes are, but we do want to return something different than just the response here.
- Assigned to brianperry
- 🇺🇸United States brianperry
Pushed up an update that resolves recent merge conflicts.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 5:56pm 30 November 2023 - 🇺🇸United States brianperry
I've made the remaining updates. Setting to needs review.
- Status changed to Needs work
about 1 year ago 12:20am 1 December 2023 - Status changed to Needs review
about 1 year ago 4:21pm 8 December 2023 - Status changed to RTBC
about 1 year ago 4:29pm 8 December 2023 Thanks to all of the contributors on this one: abhisekmazumdar, shrutishende, brianperry, and pratik_kamble!
- Status changed to Fixed
about 1 year ago 4:33pm 8 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.