🇮🇳India @abhisekmazumdar

@l_vandamme I hope keeping the seo_fields as a sequence type will be fine. I have updated the MR; please review.

This is ready for review.

abhisekmazumdar → created an issue.

hestenet → credited abhisekmazumdar → .

surabhi-gokte → credited abhisekmazumdar → .

I changed the docs to use PHP attributes instead of comment annotations.

Oh yes! We should consider adding default blog content that includes a comment?

Let me know how we feel about this. This is up for review now.

Help the camp team with maintaining, development and managing the site.

I want to work on this.

1. The boilerplate or template for the recipe can be: https://git.drupalcode.org/project/drupal_cms/-/blob/0.x/drupal_cms_blog....
   Right?
2. How do we want to spam protection?

• Do we use any contributed modules, such as CAPTCHA or Honeypot?
• Or we use the core's content moderation to add a state to approve comments.

griffynh → credited abhisekmazumdar → .

@stefdewa I hope you don't mind that I tried to spend some time moving this forward with @wim leers' input.

I also made an oopsie and added an unwanted commit to it, which I undid and fixed.

Added a new commit for the docs/data-model.md changes. I hope thats correct changes.

Now I want to understand how can I create a correct format props JSON blob for /tests/modules/xb_test_config_node_article/config/install/field.field.node.article.field_xb_test.yml

Then maybe eventually I can fix the other broken test cases.

abhisekmazumdar → made their first commit to this issue’s fork.

I don't understand the error for: https://git.drupalcode.org/issue/experience_builder-3462160/-/jobs/28517...

Can someone provide feedback or fix this ?

Can we resume work on this ?

Test cases are not my friend. Can someone either fix them or provide me with input on why all the test cases are complaining about the new exception not being found?

https://git.drupalcode.org/issue/experience_builder-3462160/-/jobs/27664...

I'm working on fixing the test case before moving it for review.

Okay, I was successfully able to make the debugger work. It works out of the box, but I need to click the continue button one more time to stop it at the required mark.

@Wim Leers

I see mostly the \Drupal\Tests\experience_builder\Kernel\DataType\ComponentTreeStructureTest::testValidation is creating problem. For our case should we just update providerValidation data to match it with what its actually trying to assert?

Or should I be looking at why the assertion is breaking ?

I tried setting up the xdebugger on my local machine to make it work with the current local setup I have. Setting up the xdebugger correctly will give me a much clearer idea of what is breaking during the test.
Yet I was unable to make Xdebugger work for the unit test cases.

Yes it works 🎉 : https://mr253-cojczkjc816gddq8fdjhi8vgvfblp7k3.tugboatqa.com/xb/node/1

I will check and rebuild the XB with a fresh setup. Some of the outstanding TODO have been fixed:

Remaining TODO:

1. I see the CI is failing for phpcs which are unrelated to this MR.
2. The Cypress tests are also failing for which I'm not sure about.

For these, I still need feedback.

The MR is ready for review.

Picking this up and giving my best try.

Done:

• Made all the suggested changes to the best of my knowledge.

Todo:

1. The ComponentPropsForm is not working for the above said reasons.
2. I see the CI is failing for phpcs which are unrelated to this MR.
3. The Cypress tests are also failing for which I'm not sure about.

Please review and give feedback.

Not sure why we still see

Loading Experience Builder…

for /xb/node/1

Also

griffynh → credited abhisekmazumdar → .

The MR looks good:

• The Preview works: "You should see a link under the MR to the preview. Once this is merged in, that link will show on any MRs."
• Username/password: admin/admin
• Node is created with hero image. Which is perfect.

TODO:

Build the React app. Steps mentioned on MR comment.

@q0rban, this is your world. How can we leverage this into the config.yml file? I see the WIP MR.

I can only think of a custom drush command, but I'm not sure if that would be overkill for this requirement. Alternatively, may be we could script this out and use it in the config.yml.

I will keep my eye on the MR.

I don't see a programmatic way to create that node. I guess may be we do something with drush generate-content

I guess this changes will be somewhat like: https://www.drupal.org/project/drupal_cms/issues/3471003 →

Thank you, @Wim Leers, for the detailed input & believing in me 😁

🏓 The MR is still a work in progress, so it is not completely ready for review. However, I seek some answers to the questions I have asked over the MR. Really appreciate your help.

I will need some more help here. This is what I understand so far:

1. I'm able to stop the debugger for ComponentTreeStructure and see the different structure for the components which now don't have the sdc names.
2. In the WIP MR, I have made the changes suggested in #6(Point 1) and description.
3. I export config and compare the newly created YAML for field.field.node.article.field_xb_demo, which doesn't have much of a difference in the config nor for the default content.
4. I can run phpunit -c core modules/contrib/experience_builder/tests/src/Kernel/DataType/ComponentTreeStructureTest.php and see it all green.
5. I understand that I still need to make changes to Constraint\ComponentTreeStructureConstraintValidator but I'm not sure how and where.

This is what I need to understand:

1. How can I ensure that what I'm doing for the ComponentTreeStructureTest is correct? I don't fully understand the tests.
2. Again, what changes will be needed for ComponentTreeStructureConstraintValidator, and how can I debug it?

I also understand this is a critical issue, and unassigning this from me. If someone already has the experience to do it quickly, please take it over.
I will pick it up if I get my answer or figure it out.

abhisekmazumdar → changed the visibility of the branch 3469609-component-tree-component-config-entity-ids to active.

abhisekmazumdar → changed the visibility of the branch 3469609-component-tree-component-config-entity-ids to hidden.

This makes sense to me. I will make these changes.

I want to pick this up but before that, can I get some doubts:

1. Do we need to make changes to ComponentTreeStructure so that the said format of config are generated?
2. All of these changes are only resticted to the field ComponentTreeItem's tree prop?
3. To make it work in the existing system locally, I will just need to create a layout using these said components?

This looks good. We can merge it.

pameeela → credited abhisekmazumdar → .

Oh, I did remember facing this issue, but a fresh setup with 11.x and using a different image made it work. However, I understand that it is related to how the image is named.

hestenet → credited abhisekmazumdar → .

griffynh → credited abhisekmazumdar → .

Interesting idea. If you are open to it, open an MR for this.

AjitS → credited abhisekmazumdar → .

rahul.shinde → credited abhisekmazumdar → .

Closing as it outdated now.

I have created a new MR for 2.0.x and closed the old one.

This is open for review now.

Thank you for the MoM.

Thank you @naveenvalecha for the inputs I have update the MR as per you suggestion.

abhisekmazumdar → created an issue.

I feel this can be reviewed now. A third perspective may identify aspects I might have overlooked.

abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to active.

abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.

abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.

abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.

rahul.shinde → credited abhisekmazumdar → .

abhisekmazumdar → made their first commit to this issue’s fork.

hestenet → credited abhisekmazumdar → .

I have added a new field under the form. The field will have the only property specific blacklist config.
With the new changes, the property will not be unset but will be left blank.

This can be tested now. Please help me find any remaining corner cases I might have missed.

I tested the drush command by running:

drush convivial_content-import news --cleanup=1 -y

Got the following output:

 // Are you sure you want to import content from the datasource news?: yes.

The import process for the news dataset has been successfully completed.
The following entities were imported during the process: taxonomy_term, media, paragraph, block_content, node

and

drush convivial_content-import bookshop --cleanup=1 -y

Output:

// Are you sure you want to import content from the datasource bookshop?: yes.

 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
 [warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
The import process for the bookshop dataset has been successfully completed.
The following entities were imported during the process: taxonomy_term, media, paragraph, block_content, node
 [warning] The field Rendered HTML output (rendered_item) on index Content is missing view mode configuration for some datasources or bundles. Please review (and re-save) the field settings.

Data was successfully imported into an existing Convivial site.

I think we need another function where we can pass an additional argument to the `drush site-install` command to use a specific dataset if needed. For now I'm marking this as RTBC as it achieves our goal.

abhisekmazumdar → changed the visibility of the branch 3425448-add-a-drush to active.

abhisekmazumdar → changed the visibility of the branch 3425448-add-a-drush to hidden.

Upon reviewing the test cases, I found that most of the failed cases are related to:

Drupal\Tests\metatag_custom_tags\Functional\CustomMetaTagPropertyTest::testCustomMetaTagPropertyWithPrefix
Behat\Mink\Exception\ExpectationException: Current page is "/admin/config/search/metatag/custom-meta/add", but "/admin/config/search/metatag/custom-meta" expected.

Which basically points to a single file: https://git.drupalcode.org/project/metatag/-/merge_requests/94/diffs#c3a...

I think the values are not set correctly, so the page redirection is not happening. To confirm if the data is stored, I check the page redirection and the confirmed saved message.

I also tried using the page session variable to save the values, but it didn't help redirecting the page after saving successfully.

    $page = $this->getSession()->getPage();

    $page->selectFieldOption('attribute', $attribute);
    $page->fillField('label', 'foo');
    $page->fillField('description', 'foo description');
    $page->pressButton('Save');

I tested the changes and the new approach on #MR5. It works exactly as we were looking for in this issue.

The MR23 functions correctly and logs an error in Drupal. I'm marking this as RTBC.

Here the Github PR: https://github.com/simplytestme/website/pull/321

I also faced a similar issue. Rebuilding the queue and generating the site maps solved the problem.

+++ b/src/AugmentorManager.php
@@ -92,15 +92,44 @@ class AugmentorManager extends DefaultPluginManager {
+      $this->logger('augmentor')->error($e->getMessage());

The logger service is not found.

I get the following error:

Call to undefined method Drupal\augmentor\AugmentorManager::logger()

I tested the #5 MR and for Drupal 8 and above sites the error_level is set to verbose out of the box.

I might be wrong but I feel these changes should have been part of https://git.drupalcode.org/project/simplytest/-/blob/8.x-4.x/themes/simp...
Not the Github repo.

I was able to spin up sites with Drupal 9.x or Drupal 7.x respectively.

Thank you @Akhil Babu for a detailed #6 comment.

I see the radix → theme is something which is not straight forward which can be tested on simplytest site. It requires additional dependencies that are more specific to the radix theme.

I installed the latest version of the module from https://www.drupal.org/project/a11y_autocomplete_element → .

I will review this.

At this point, I can no longer reproduce this issue.

I can confirm this has been fixed and deployed.

I was able to install https://ftp.drupal.org/files/projects/devel-5.1.2.tar.gz and install it in a demo site.

I will review the open MR.

This seems like a good place to begin the d10 upgrade work, starting with adding support for PHP 8.1.

I was able to setup a site with context module required and installed.

It appears that this is up for review. I will attempt to test it once I have the necessary access.

Looks like the error on #6 is related to #3405187 →

I gave some more thinking to it and believe it's acceptable to skip and proceed with the site installation process. We have already virtually created the site, and at this point(composer is installing the dependency.).

However, I agree that the skipped patch error should be emphasized more. I'm unsure if it's possible or if the project maintainers are open to achieving this.

I can confirm that the said issue exists and applying the patch is skipped.

https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2 (STM patch 7bd5d37bb6926152fd9cca21cc565824e6b034f2)
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2

A high-level analysis from my side:

I assume while creating a new site the cweagans/composer-patches has a default value for composer-exit-on-patch-failure as false. We will need to add composer-exit-on-patch-failure as true to the composer.json for the newly created site.
https://github.com/cweagans/composer-patches/tree/1.7.3?tab=readme-ov-fi...

@mglaman thanks for the MR.

I'm marking this as Unassigned because I see an MR is open for review.

Changing this to "Needs review" because I believe it requires further investigation and review before it can be implemented.

I tried the latest patch #11 but for me it doesn't work when its a chosen-container-single

So I investigated this issue and found that some how when Minimum width of widget is not set in the Config. by default a inline style is set that is width: 99px.

I created a fix by setting a default to auto when no width is configured at Drupal end.
MR11 will be the fix for this.

abhisekmazumdar → made their first commit to this issue’s fork.

Works like a charm. Thank you for the fix.

abhisekmazumdar → made their first commit to this issue’s fork.