🇮🇳India @abhisekmazumdar

abhisekmazumdar → created an issue.

Thank You.

Made the changes. Please review the two new actions for DNC.

Conflict resolved. Thank you.

Thank you. This is a merge to the development branch. A release will be created soon with a few other similar actions are merged.

Thank you for the improvements. It's great to see how everything fits together like Lego pieces.

Thank you for the feedback.
I have addressed all the inline comments, please review them.
I also moved the relevant helper API method to mautic_api: 📌 Add helper method loadConnection & checkApiResponse Active

abhisekmazumdar → created an issue.

I was not feeling happy with the structure. I made some adjustments to the overall structure to align it with the other actions.
A new commit: https://git.drupalcode.org/project/mautic_eca/-/merge_requests/1/diffs?c...

Thank you for the improvement. This is good to go.

abhisekmazumdar → made their first commit to this issue’s fork.

Thank you, @mallezie, for the improvement.

This enhancement makes the code cleaner and more maintainable, significantly enhancing the developer experience.

I have made a small fix to the merge request and added a new commit. Everything else looks great, so I'll proceed to merge this and create a new minor release tag.

abhisekmazumdar → made their first commit to this issue’s fork.

Thank you for the detailed review and for fixing the bugs. I have now merged the MR.

New changes done:

• My bad, the check of the old and new secret wasn't behaving well. I break it down and added proper checks.
• Also moved the config under web services where it made more sense.
• Made improvements to the consistency for the "mautic api connection" to "Mautic API Connection".

In the overview it might make more sense in the status to show the result of the connection test.

I didn't add that because the status is not stored in the entity(database). To obtain the status of an API, we need to load the entire entity and make request for status all the connection entities. This might become problematic as we start to have more connection entities in the overview listing.

I just replaced the status with the site URL, which makes it easier to identify.

• I made the error handling better.
• Clear value if the auth method is toggled
• Rename the oauth to the said public and secret keys
• moved the status message in the top and just shows error msg doesn't show WSOD

All the other MR inline feedback has also been resolved now.

abhisekmazumdar → created an issue.

abhisekmazumdar → created an issue.

abhisekmazumdar → created an issue.

abhisekmazumdar → created an issue.

This should be merged after: 📌 Implement CRUD for Mautic contacts Active

Note merged this after: 📌 Implement CRUD for Mautic contacts Active

abhisekmazumdar → created an issue.

This task is based on this MR from mautic_api

abhisekmazumdar → created an issue.

This work is based on the related issue.

This work is based on this related issue.

abhisekmazumdar → created an issue.

abhisekmazumdar → created an issue.

Thank you for the quick response.

abhisekmazumdar → changed the visibility of the branch 3527905-multi-instance-mautic-connection to hidden.

abhisekmazumdar → changed the visibility of the branch 2.0.x to hidden.

abhisekmazumdar → changed the visibility of the branch 3527905-implement-multi-instance-mautic to hidden.

abhisekmazumdar → created an issue.

abhisekmazumdar → created an issue.

Outdated

I don't think core_version_requirement is needed to be added in composer.json file.

I also suggest following this document to create a good branch name: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Anyways, thanks for your time. I'm closing this and making a new release for d11.

rahul.shinde → credited abhisekmazumdar → .

@l_vandamme I hope keeping the seo_fields as a sequence type will be fine. I have updated the MR; please review.

This is ready for review.

abhisekmazumdar → created an issue.

hestenet → credited abhisekmazumdar → .

surabhi-gokte → credited abhisekmazumdar → .

I changed the docs to use PHP attributes instead of comment annotations.

Oh yes! We should consider adding default blog content that includes a comment?

Let me know how we feel about this. This is up for review now.

Help the camp team with maintaining, development and managing the site.

I want to work on this.

1. The boilerplate or template for the recipe can be: https://git.drupalcode.org/project/drupal_cms/-/blob/0.x/drupal_cms_blog....
   Right?
2. How do we want to spam protection?

• Do we use any contributed modules, such as CAPTCHA or Honeypot?
• Or we use the core's content moderation to add a state to approve comments.

griffynh → credited abhisekmazumdar → .

@stefdewa I hope you don't mind that I tried to spend some time moving this forward with @wim leers' input.

I also made an oopsie and added an unwanted commit to it, which I undid and fixed.

Added a new commit for the docs/data-model.md changes. I hope thats correct changes.

Now I want to understand how can I create a correct format props JSON blob for /tests/modules/xb_test_config_node_article/config/install/field.field.node.article.field_xb_test.yml

Then maybe eventually I can fix the other broken test cases.

abhisekmazumdar → made their first commit to this issue’s fork.

I don't understand the error for: https://git.drupalcode.org/issue/experience_builder-3462160/-/jobs/28517...

Can someone provide feedback or fix this ?

Can we resume work on this ?

Test cases are not my friend. Can someone either fix them or provide me with input on why all the test cases are complaining about the new exception not being found?

https://git.drupalcode.org/issue/experience_builder-3462160/-/jobs/27664...

I'm working on fixing the test case before moving it for review.

Okay, I was successfully able to make the debugger work. It works out of the box, but I need to click the continue button one more time to stop it at the required mark.

@Wim Leers

I see mostly the \Drupal\Tests\experience_builder\Kernel\DataType\ComponentTreeStructureTest::testValidation is creating problem. For our case should we just update providerValidation data to match it with what its actually trying to assert?

Or should I be looking at why the assertion is breaking ?

I tried setting up the xdebugger on my local machine to make it work with the current local setup I have. Setting up the xdebugger correctly will give me a much clearer idea of what is breaking during the test.
Yet I was unable to make Xdebugger work for the unit test cases.

Yes it works 🎉 : https://mr253-cojczkjc816gddq8fdjhi8vgvfblp7k3.tugboatqa.com/xb/node/1

I will check and rebuild the XB with a fresh setup. Some of the outstanding TODO have been fixed:

Remaining TODO:

1. I see the CI is failing for phpcs which are unrelated to this MR.
2. The Cypress tests are also failing for which I'm not sure about.

For these, I still need feedback.

The MR is ready for review.

Picking this up and giving my best try.

Done:

• Made all the suggested changes to the best of my knowledge.

Todo:

1. The ComponentPropsForm is not working for the above said reasons.
2. I see the CI is failing for phpcs which are unrelated to this MR.
3. The Cypress tests are also failing for which I'm not sure about.

Please review and give feedback.

Not sure why we still see

Loading Experience Builder…

for /xb/node/1

Also

griffynh → credited abhisekmazumdar → .

The MR looks good:

• The Preview works: "You should see a link under the MR to the preview. Once this is merged in, that link will show on any MRs."
• Username/password: admin/admin
• Node is created with hero image. Which is perfect.

TODO:

Build the React app. Steps mentioned on MR comment.

@q0rban, this is your world. How can we leverage this into the config.yml file? I see the WIP MR.

I can only think of a custom drush command, but I'm not sure if that would be overkill for this requirement. Alternatively, may be we could script this out and use it in the config.yml.

I will keep my eye on the MR.

I don't see a programmatic way to create that node. I guess may be we do something with drush generate-content

I guess this changes will be somewhat like: https://www.drupal.org/project/drupal_cms/issues/3471003 →

Thank you, @Wim Leers, for the detailed input & believing in me 😁

🏓 The MR is still a work in progress, so it is not completely ready for review. However, I seek some answers to the questions I have asked over the MR. Really appreciate your help.

I will need some more help here. This is what I understand so far:

1. I'm able to stop the debugger for ComponentTreeStructure and see the different structure for the components which now don't have the sdc names.
2. In the WIP MR, I have made the changes suggested in #6(Point 1) and description.
3. I export config and compare the newly created YAML for field.field.node.article.field_xb_demo, which doesn't have much of a difference in the config nor for the default content.
4. I can run phpunit -c core modules/contrib/experience_builder/tests/src/Kernel/DataType/ComponentTreeStructureTest.php and see it all green.
5. I understand that I still need to make changes to Constraint\ComponentTreeStructureConstraintValidator but I'm not sure how and where.

This is what I need to understand:

1. How can I ensure that what I'm doing for the ComponentTreeStructureTest is correct? I don't fully understand the tests.
2. Again, what changes will be needed for ComponentTreeStructureConstraintValidator, and how can I debug it?

I also understand this is a critical issue, and unassigning this from me. If someone already has the experience to do it quickly, please take it over.
I will pick it up if I get my answer or figure it out.

abhisekmazumdar → changed the visibility of the branch 3469609-component-tree-component-config-entity-ids to active.

abhisekmazumdar → changed the visibility of the branch 3469609-component-tree-component-config-entity-ids to hidden.