rahul.shinde → credited abhisekmazumdar → .
Closing as it outdated now.
I have created a new MR for 2.0.x and closed the old one.
This is open for review now.
Thank you for the MoM.
Thank you @naveenvalecha for the inputs I have update the MR as per you suggestion.
abhisekmazumdar → created an issue.
I feel this can be reviewed now. A third perspective may identify aspects I might have overlooked.
abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to active.
abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.
abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.
abhisekmazumdar → changed the visibility of the branch 3439817-use-the-drupal to hidden.
rahul.shinde → credited abhisekmazumdar → .
abhisekmazumdar → made their first commit to this issue’s fork.
hestenet → credited abhisekmazumdar → .
I have added a new field under the form. The field will have the only property specific blacklist config.
With the new changes, the property will not be unset but will be left blank.
This can be tested now. Please help me find any remaining corner cases I might have missed.
I tested the drush command by running:
drush convivial_content-import news --cleanup=1 -y
Got the following output:
// Are you sure you want to import content from the datasource news?: yes.
The import process for the news dataset has been successfully completed.
The following entities were imported during the process: taxonomy_term, media, paragraph, block_content, node
and
drush convivial_content-import bookshop --cleanup=1 -y
Output:
// Are you sure you want to import content from the datasource bookshop?: yes.
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
[warning] The "block_content:4e31f517-2dc8-4a9d-87fb-b39ba498687f" was not found
The import process for the bookshop dataset has been successfully completed.
The following entities were imported during the process: taxonomy_term, media, paragraph, block_content, node
[warning] The field Rendered HTML output (rendered_item) on index Content is missing view mode configuration for some datasources or bundles. Please review (and re-save) the field settings.
Data was successfully imported into an existing Convivial site.
I think we need another function where we can pass an additional argument to the `drush site-install` command to use a specific dataset if needed. For now I'm marking this as RTBC as it achieves our goal.
abhisekmazumdar → changed the visibility of the branch 3425448-add-a-drush to active.
abhisekmazumdar → changed the visibility of the branch 3425448-add-a-drush to hidden.
Upon reviewing the test cases, I found that most of the failed cases are related to:
Drupal\Tests\metatag_custom_tags\Functional\CustomMetaTagPropertyTest::testCustomMetaTagPropertyWithPrefix
Behat\Mink\Exception\ExpectationException: Current page is "/admin/config/search/metatag/custom-meta/add", but "/admin/config/search/metatag/custom-meta" expected.
Which basically points to a single file: https://git.drupalcode.org/project/metatag/-/merge_requests/94/diffs#c3a...
I think the values are not set correctly, so the page redirection is not happening. To confirm if the data is stored, I check the page redirection and the confirmed saved message.
I also tried using the page session variable to save the values, but it didn't help redirecting the page after saving successfully.
$page = $this->getSession()->getPage();
$page->selectFieldOption('attribute', $attribute);
$page->fillField('label', 'foo');
$page->fillField('description', 'foo description');
$page->pressButton('Save');
I tested the changes and the new approach on #MR5. It works exactly as we were looking for in this issue.
The MR23 functions correctly and logs an error in Drupal. I'm marking this as RTBC.
Here the Github PR: https://github.com/simplytestme/website/pull/321
I also faced a similar issue. Rebuilding the queue and generating the site maps solved the problem.
+++ b/src/AugmentorManager.php
@@ -92,15 +92,44 @@ class AugmentorManager extends DefaultPluginManager {
+ $this->logger('augmentor')->error($e->getMessage());
The logger service is not found.
I get the following error:
Call to undefined method Drupal\augmentor\AugmentorManager::logger()
I tested the #5 MR and for Drupal 8 and above sites the error_level
is set to verbose
out of the box.
I might be wrong but I feel these changes should have been part of https://git.drupalcode.org/project/simplytest/-/blob/8.x-4.x/themes/simp...
Not the Github repo.
I was able to spin up sites with Drupal 9.x or Drupal 7.x respectively.
I installed the latest version of the module from https://www.drupal.org/project/a11y_autocomplete_element → .
I will review this.
At this point, I can no longer reproduce this issue.
I can confirm this has been fixed and deployed.
I was able to install https://ftp.drupal.org/files/projects/devel-5.1.2.tar.gz and install it in a demo site.
I will review the open MR.
This seems like a good place to begin the d10 upgrade work, starting with adding support for PHP 8.1.
I was able to setup a site with context module required and installed.
It appears that this is up for review. I will attempt to test it once I have the necessary access.
Looks like the error on #6 is related to #3405187 →
I gave some more thinking to it and believe it's acceptable to skip and proceed with the site installation process. We have already virtually created the site, and at this point(composer is installing the dependency.).
However, I agree that the skipped patch error should be emphasized more. I'm unsure if it's possible or if the project maintainers are open to achieving this.
I can confirm that the said issue exists and applying the patch is skipped.
https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2 (STM patch 7bd5d37bb6926152fd9cca21cc565824e6b034f2)
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/issue/drupal-3273986/-/commit/7bd5d37bb6926152fd9cca21cc565824e6b034f2
A high-level analysis from my side:
I assume while creating a new site the cweagans/composer-patches
has a default value for composer-exit-on-patch-failure
as false. We will need to add composer-exit-on-patch-failure
as true to the composer.json for the newly created site.
https://github.com/cweagans/composer-patches/tree/1.7.3?tab=readme-ov-fi...
@mglaman thanks for the MR.
I'm marking this as Unassigned because I see an MR is open for review.
Changing this to "Needs review" because I believe it requires further investigation and review before it can be implemented.
I tried the latest patch #11 but for me it doesn't work when its a chosen-container-single
So I investigated this issue and found that some how when Minimum width of widget is not set in the Config. by default a inline style is set that is width: 99px
.
I created a fix by setting a default to auto when no width is configured at Drupal end.
MR11 will be the fix for this.
abhisekmazumdar → made their first commit to this issue’s fork.
Works like a charm. Thank you for the fix.
abhisekmazumdar → made their first commit to this issue’s fork.
The patch in #9 works and displays the pop-up, but it does not allow typing in the input box.
The patch in this issue:
https://www.drupal.org/project/drupal/issues/3328425#comment-14845336
🐛
CKEditor 5 balloons invisible when CKEditor 5 is used inside a modal
Needs work
Works for me.
Cross-checking it again on a live environment, I encountered the following error:
Fatal error: Trait "DependencySerializationTrait" not found in /code/web/modules/contrib/augmentor_nlpcloud/src/NPLCloudBase.php on line 22
Changes work as expected.
Apologies for the delay. I attempted to debug the failed test cases but was not successful. I will continue investigating, but I'm leaving this issue open for the community to assist.
@eleonel
When I use Text Generation(NLP Cloud) for this. I get 500 error.
The db log says something like this:
LogicException: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution. in Drupal\Core\Database\Connection->__sleep() (line 1712 of /code/web/core/lib/Drupal/Core/Database/Connection.php).
abhisekmazumdar → created an issue.
Works as expected.
This is amazing. Thank you.
Works as expected.
Thank you, @eleonel, for the patch. It is working as expected.
abhisekmazumdar → created an issue.
Thank you for the patch @eleonel
Using https://github.com/nlpcloud/nlpcloud-php/blob/master/src/NLPCloud.php#L209 as an alternative to article generation.
Thanks @eleonel for the patch.
@eleonel Thanks for the patch.
Thank you, @eleonel, for the patch.
abhisekmazumdar → created an issue.
Thank you for the review. It has been merged, and a new minor release will be created for this.
abhisekmazumdar → created an issue.
Looks like there are some changes in the ChatGPT error response structure. I have updated the MR accordingly.
A simple curl response shows the new format:
curl https://api.openai.com/v1/chat/completions \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $OPENAI_API_KEY" \
-d '{
"model": "gpt-3.5-turbo",
"messages": [],
"temperature": 0,
"max_tokens": 256
}'
{
"error": {
"message": "You didn't provide an API key. You need to provide your API key in an Authorization header using Bearer auth (i.e. Authorization: Bearer YOUR_KEY), or as the password field (with blank username) if you're accessing the API from your browser and are prompted for a username and password. You can obtain an API key from https://platform.openai.com/account/api-keys.",
"type": "invalid_request_error",
"param": null,
"code": null
}
}
abhisekmazumdar → made their first commit to this issue’s fork.
abhisekmazumdar → created an issue.
I have review the MR. I was able to install the module with the changes.
A WIP MR has been raised. I will be working the following now:
- Converting the configurations to Config Entity.
- Code standards and improvements.
Looks for more feedbacks. Thank you.
Assigning this to myself. I will be trying to port this module as a sub-module.
I trust that the approach I have taken is a viable way. I am seeking additional input from the maintainers of the module.
abhisekmazumdar → made their first commit to this issue’s fork.
The patch #20 makes the module installable in Drupal's latest version 10.
Thank you @eleonel for the updated patch.
Looking for feedback also I will need some inputs for the test case.
Will the Mocks file for this will be txt file or json file is only required.
Picking this up.
abhisekmazumdar → created an issue.
I can confirm that after I upgraded this module from `drupal/gtranslate` 1.15.0 to 3.0.1 with Drupal 9.5, I am experiencing the mentioned WSFD with these error messages.
Applying these patches resolves the issue.
I can confirm that after I upgraded this module from `drupal/gtranslate` 1.15.0 to 3.0.1 with Drupal 9.5, I am experiencing the mentioned WSFD with these error messages.
Applying these patches resolves the issue.
@Indrapatil, as mentioned by @apaderno, your merge request has many unwanted changes. I have created a new MR from the latest development branch and closed the old MR.
The MR is up for review.
abhisekmazumdar → made their first commit to this issue’s fork.
I tried to remove anything that was created by the install hook and needed to be removed. Not everything needed to be deleted, so I only removed:
- DpPreviewSite - example_nextjs_preview
- user - pantheon_decoupled
- role - pantheon_decoupled
Looks like the mentioned issue #3 has been merged: https://www.drupal.org/project/pathauto/issues/3328670#comment-15128999 📌 PHP 8.2 compatibility Fixed .
I tested it locally using https://github.com/pantheon-upstreams/decoupled-drupal-10-composer-managed/. This issue doesn't seem to be occurring. The recent log is also all green. It's good to close it now.
abhisekmazumdar → made their first commit to this issue’s fork.
Sadly, I had to reopen this as I found a bug with the block ID when we are placing the same block in multiple regions.
Thank you for your suggestion, @naveenvalecha.