- Issue created by @abhisekmazumdar
- @abhisekmazumdar opened merge request.
- 🇮🇳India abhisekmazumdar India
I was not feeling happy with the structure. I made some adjustments to the overall structure to align it with the other actions.
A new commit: https://git.drupalcode.org/project/mautic_eca/-/merge_requests/1/diffs?c... - 🇮🇳India abhisekmazumdar India
Thank you for the feedback.
I have addressed all the inline comments, please review them.
I also moved the relevant helper API method to mautic_api: 📌 Add helper method loadConnection & checkApiResponse Active - 🇧🇪Belgium mallezie Loenhout
We do not need the json field in every plugin, so removed that and made the needed changes.
Also removed the 2 helper functions, no need to block that on the new issue in mautic_api, that's a good improvement, but can be postponed to later.
There is still one thing missing here, that is the ListContact action, i'll push that tomorrow, if we have that one, then we can start with a setup like delete from mail, by combining that action. - 🇧🇪Belgium mallezie Loenhout
Added the mautic list action.
This can be used to find a contact via mail, store that output in a token, and then use that input (or part of it) as input token for a get or delete contact.
-
abhisekmazumdar →
committed 211b5c73 on 1.0.x
Issue #3530306 by abhisekmazumdar, mallezie: Implement CRUD ECA Actions...
-
abhisekmazumdar →
committed 211b5c73 on 1.0.x
- 🇮🇳India abhisekmazumdar India
Thank you for the improvements. It's great to see how everything fits together like Lego pieces.
Automatically closed - issue fixed for 2 weeks with no activity.