- Issue created by @pratik_kamble
- @pratik_kamble opened merge request.
- Issue was unassigned.
- Status changed to Needs review
10 months ago 8:18pm 12 September 2023 - Assigned to shrutishende
- I ran the pnpm prepare command to set up Git hooks using Husky.
- I made a deliberate formatting error in the examples/json-api-client/src/main.ts file.
- When I attempted to commit my changes using the git commit command, I encountered a linting error.
- I also verified that all the commands within the pre-commit hooks were executed as expected.
- Issue was unassigned.
- Status changed to RTBC
9 months ago 9:47am 2 October 2023 - First commit to issue fork.
-
brianperry →
committed 8a4f1cc5 on canary authored by
pratik_kamble →
Issue #3386860 by pratik_kamble, shrutishende: Configure pre-commit hook...
-
brianperry →
committed 8a4f1cc5 on canary authored by
pratik_kamble →
- 🇺🇸United States brianperry
On past projects heard some feedback about the commit hooks being a barrier for folks, but we talked things over in Slack and the consensus was to add them. We can always revisit this if it is a problem for people.
Thanks @pratik_kamble and @shrutishende
- Status changed to Fixed
9 months ago 7:52pm 2 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.