Replace Node.js Buffer with Unit8Array

Created on 31 October 2023, almost 2 years ago

Updated 15 November 2023, almost 2 years ago

Problem/Motivation

From @coby.sher in slack: https://drupal.slack.com/archives/C05BP6659U0/p1698411217734069?thread_t...

> An interesting article here on Node.js Buffer and why we maybe shouldn’t use it! TLDR: Apparently under the hood it’s the same as a Unit8Array which is valid in both the browser AND node, while Buffer is node.js only. The article suggests moving away from Buffer and using Unit8Array and a util they made for things like base64 encoding.
We may want to replace our esbuild polyfill stuff with this approach.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Component

Code

Created by

🇺🇸United States brianperry

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @brianperry
Comment almost 2 years ago →
🇺🇸United States brianperry
First commit to issue fork.
@pratik_kamble opened merge request.
Status changed to Needs review almost 2 years ago7:55pm 1 November 2023
Comment almost 2 years ago →
🇮🇳India pratik_kamble Pune, India
Status changed to RTBC almost 2 years ago8:18pm 1 November 2023
Comment almost 2 years ago →
coby.sher
Status changed to Fixed almost 2 years ago3:14pm 15 November 2023
Comment almost 2 years ago →
🇺🇸United States brianperry
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024