This works perfectly if the data-entity-type and data-entity-uuid attributes are added to the tag. However, in my install, when uploading a new image via imce (3.1.2 or 3.1.3) and then adding that image in CKEditor, I am not seeing any data attributes.
Is there some additional configuration in imce or ckeditor required to get the data attributes to be included?
cobblestone.consulting β created an issue.
I am also seeing this issue. It happens whenever another module has been un-installed, but before caches have been rebuilt.
cobblestone.consulting β created an issue.
Thanks, @mailein, I have added your screenshot to the documentation page.
cobblestone.consulting β created an issue.
Thanks for the report @maxilein. Release 1.0.1 address this issue. Please confirm
Thanks @maxilein for the report and @sarwan_verma for the MR. I have an updated 1.1.x branch ready to go that I will release when I've had a chance to do some testing.
cobblestone.consulting β created an issue.
Issue linked in #7 has been closed. Closing.
Thanks @bhogue, I have updated the module page with the missing details.
If you are still having trouble with the import feature, please provide additional details on what you mean by it "failed". Was there an error?
cobblestone.consulting β created an issue.
@maxilein, please see #3
Hi @maxilein,
I have re-reviewed this issue and realized that there is already a drush.services.yml file so I have reverted the update to services.yml. As I mentioned, I am not able to reproduce this issue on a couple of different sites/installs so I am closing this issue.
Please try: drush cc drush and see if that helps.
If you are still seeing this issue, please re-open if you are able to provide any additional details.
Hi @maxilein,
I am not able to reproduce this issue locally on a minimal install. However, I created a service definition for the drush command and pushed it to the 1.0.0-dev branch. Please let me know if this fixes the issue.
Fix is in place now in 1.0.0. Please review @vishalnewt.
thanks!
This was addressed in beta4
This feature has been merged and will be included in the next release. It will also be available in the next roll of the dev release.
I would be happy to include a drush command, esp. since you provided it. Thanks for that. I was more focused on the config aspect of the request when I closed this.
Can you create an MR for this?
Hi @mailein,
Looks like I wasn't handling uninstalled modules. Fix is available in dev branch. I'll roll this into a new beta release later this week.
Thanks for the suggestion @datawench. There is currently import/export functionality, though it does not use the config system since that is not where the data is stored.
You can find these options at Extend -> Documentation -> Export ( or Import). You should be able to take the file created/downloaded from Export and upload it on a different (or the same) site/environment to (re)populate all of the data entered through this module.
Note that it will overwrite all existing data (records that have the same IDs) though it won't delete newer records on the target environment that don't have a corresponding/matching ID in the import file.
@ultimike, Will roll this into the next release.
This is addressed in the Beta1 release
I have addressed this issue in the Beta1 release
@ultimike - I am not seeing this issue on Chrome, FF or Edge unless I shrink the width of the window to something very narrow. I'll see what I can come up with but I'd welcome any suggestions for addressing this.
Template updates to fix this issue will be pushed in the next release
Updated patch to address eslint issues.
Yes, that's probably a good idea.
Patch was added to module_filter issue ( https://www.drupal.org/project/module_filter/issues/3418465#comment-1542... π Make compatible with other UI functionality like Module Usage Documentation Active ) that addresses the issue mentioned in my previous comment.
Minor update to previous patch - added missing arguments to attach() funciton.
Here's a patch that should take care of this issue.
I have updated the template handling in the alpha4 release to add support for module_filter.
There is still an issue, though, when a module_usage accordion is initially opened. An ajax call is being made to retrieve the module usage data. When this call is executed, module_filter's attach methods are being called again and are resetting the page - causing the "All" modules tab to be displayed and disabling most of the other tabs. I believe this is an issue with module_filter that I think could be fixed with the use of "once()" implementations.
Excellent idea @ultimike ! This is in place now.
Thanks for the suggestion @capysara. I have added created/changed fields to all tables and updated the displays. You'll need to uninstall/re-install the module to apply the updates (which will cause your test data to be lost)
@ultimike The color wasn't explicitly being set, it was using the value from the jQuery theme. That was white in my dev env. I've pushed an update that explicitly sets the colors.
Thanks for the great idea, I have pushed up a new commit with this functionality
Thanks for the report @capysara. I prefer the use of "Save" and have updated the other 2 forms to match.
Thanks for the report @capysara. I originally had code in the template that displayed the text version of the status but it was lost at some point. I have restored that in the template.
Thanks for pointing this out! There was a dependency on Fontawesome but it was removed yesterday. I will update the project page.
I was seeing errors when trying to edit an existing formatter and I found that when importing the config from a previously created formatter, only a couple of fields were being saved. (also, the listing page has all blank fields). Here is a patch that addresses these issues.
Upgrade status was reporting the same error mentioned in #5. Here is a patch that adds a fix for that issue to the patch from #9.