🇦🇷Argentina @emacoti

Fixed and tested, it now passes d11 upgrade status. Closing.

emacoti → made their first commit to this issue’s fork.

Ok here is the patch with the update.

emacoti → created an issue.

Thank you! I will keep that in mind and try to participate and review other projects.

ok just pushed the fix for this one

FILE: /pdb_twig/src/Event/PdbTwigPreRenderAlterEvent.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 110 | ERROR | Type hint "array" missing for $class_instance
-----------------------------------------------------------------------------------------------

It was a mistake on the method documentation, had array but was object type instead.

Thanks for the review @vinaymahale.

About the "core_version_requirement" property is missing in the info.yml file, those are not actual extension like modules, those are yml file for the blocks and a custom discovery and parser will read and process them, thus making the core_version_requirement not needed. Would prefer to not add that not needed property in this case. Does that makes sense?

Will fix the other one.

emacoti → created an issue.

Merge request ready for review.

emacoti → created an issue.

emacoti → created an issue.

Created the merge request with the changes.

emacoti → created an issue.

Added the merge request with the update.

emacoti → created an issue.

New version 2.2.3 works fine for us on Drupal 9.5, thanks for the fix!

Uploading patch again as it was created against wrong version.

Added test coverage for new property and updated readme.

emacoti → created an issue.

Ok will rollback, thanks

Getting same error on Drupal 9.5.9.

Here the patch with the fixes

emacoti → created an issue.

Agreed on that. Adding a missing piece to the patch to handle existing dependencies on the defined component library like cases

add_js:
  footer:
    js:
      'lib.js': {}
    dependencies:
      - pdb/another_lib/footer

Here the patch with the fix.

emacoti → created an issue.

Tested this and works as expected. Components are recognized as before and was able to remove properties like `core_version_requirement`. Looks good to me.

Ok there was an error on a test. So new patch with the test fixed.

I consolidated the patches and the merge request into a new patch that includes all the fixes. Tested on a Drupal9 and Drupal10 site and works as expected on both.

We will probably need to cut a new alpha version before merging this as this will not work on Drupal 8 sites anymore. Wil check on that.

Patch merged. Closing out.

emacoti → created an issue.