[1.x] Decoupled Blocks: Twig

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
Reviewer's task is describing what needs to be changed, not providing patches to fix what reported in a review.

Please fix the below PHPCS issues:

---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /pdb_twig/modules/pdb_twig_examples/components/twig_example_css_js/twig_example_css_js.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
--------------------------------------------------------------------------------------------------------------------------------------------


FILE: /pdb_twig/modules/pdb_twig_examples/components/twig_example_class/twig_example_class.info.yml
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
------------------------------------------------------------------------------------------------------------------------------------------


FILE: ...lampp81/htdocs/test_drupal_modules/pdb_twig/modules/pdb_twig_examples/components/twig_example_context_node/twig_example_context_node.info.yml
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | "core_version_requirement" property is missing in the info.yml file
---------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /pdb_twig/src/Event/PdbTwigPreRenderAlterEvent.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 110 | ERROR | Type hint "array" missing for $class_instance
-----------------------------------------------------------------------------------------------

Thanks for the review @vinaymahale.

About the "core_version_requirement" property is missing in the info.yml file, those are not actual extension like modules, those are yml file for the blocks and a custom discovery and parser will read and process them, thus making the core_version_requirement not needed. Would prefer to not add that not needed property in this case. Does that makes sense?

Will fix the other one.

ok just pushed the fix for this one

FILE: /pdb_twig/src/Event/PdbTwigPreRenderAlterEvent.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 110 | ERROR | Type hint "array" missing for $class_instance
-----------------------------------------------------------------------------------------------

It was a mistake on the method documentation, had array but was object type instead.

As per comment #4 yes that can be ignored. Other than that there are no more PHPCS issues.
Let's wait for other reviewers.

I am changing priority as per Issue priorities

No issues found
Changing status to RTBC!

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

Thank you! I will keep that in mind and try to participate and review other projects.

Automatically closed - issue fixed for 2 weeks with no activity.