This is a patch that is intended for those who need to support both "url" and "full_url" while decoupled front ends make this change.
OK, so this was happening because we had no configuration in place. If there is no config, then the second parameter of array_key_exists is null, which causes the php error. There should be a null check here, or a default value of [].
Simple solution to avoid the error: Go to the config page and hit save. The error only occurs when there is not yet any configuration.
I am getting the same error - TypeError: array_key_exists(): Argument #2 ($array) must be of type array, null given in array_key_exists() (line 203 of modules/contrib/security_review/src/SecurityReview.php).
Same patch as #79 with depth 2.
#79 is not applying for me on 10.3.1
I think I had this error before doing
drush role:perm:add anonymous 'render storybook stories'
Rerolled for version beta5 and accounting for revisions.
Patch allows menu_breadcrumbs to be the only breadcrumb builder without fallback, so that if a page is not on one of the configured menus, it will not have breadcrumbs displayed.
Please disregard my prior comment/patch... this is just moving the link add above where we break on first url match.
I think this should do it... I think we need to add the item to the links before breaking out of the loop, as addMissingCurrentPage(), which adds the link using the node title, is expecting the link to already be in the $links array.
Because this analysis happens after Home is added (if that is selected), the presence of the home link makes the patch in #7 inapplicable to any page but the homepage. I tweaked the code to take into account if home has been added, so the breadcrumbs will only show if the total links are at least 3 (including HOME, self, and one other) or if home is not added, 2.
I think this behavior in may cases is preferred. Often, content intended to be consumed through jsonapi only does not have a front-end template, so you would want to hide the node page without restricting the content from being part of jsonapi calls.
Jsonapi extras allows you to block resources and fields, though not on a node-by-node basis. If this functionality is added to rabit hole, I think it should be an independent selection so that you can maintain different behavior for the front-end template vs. the jsonapi representation.
Patch to do what you are describing.
Patch from MR 32, without the testing changes
Patch against 3.0.0-beta3 for those who meed it
I would like to be maintainer of the BFF module because we are using the module and would like the ability to keep the module compatible with new versions of Drupal and add features and fixes where applicable. I am familiar with the code and can dedicate the necessary time for maintaining the module.
I am fine with whichever you prefer. For me, this is all about altering the pull form to add additional information for the content editors to see what they are pulling- the additions to the jsonapi query go hand in hand with altering the pull form. I have not used it with the CLI.
Patch against RC-4 for someone who might need it.
I committed and pushed changes to swap the hooks for events, but not figuring out how to make it mergeable.