- πΊπΈUnited States dgroene
I think this should do it... I think we need to add the item to the links before breaking out of the loop, as addMissingCurrentPage(), which adds the link using the node title, is expecting the link to already be in the $links array.
- πΊπΈUnited States dgroene
Please disregard my prior comment/patch... this is just moving the link add above where we break on first url match.
- π³πΏNew Zealand xurizaemon Εtepoti, Aotearoa π
Thanks for the patches!
We can consider this if the changed behaviour is opt-in. The existing patch looks like it implements the change you desire, but that would affect all sites using the module, and this won't be what many other sites using the module would anticipate or desire.
If implemented, this will need both a config option to enable the new behaviour, and the default behaviour should be the current behaviour. There should also be test coverage, which I can assist with.
I have updated the issue description with some more complete details and remaining tasks.
On the next code submission to this issue, let's please switch to using a merge request? (That's a request, patches are still welcome of course but MRs are preferred for collaboration and community process.)