Let modules to alter query before channel request is made to the server.

Hi,

Thanks for your feature request and the work done in it.

But instead of hooks, can you please dispatch events.

I avoid to introduce new hooks as much as possible in favor of events.

I also put some review comments in the MR.

I committed and pushed changes to swap the hooks for events, but not figuring out how to make it mergeable.

Patch against RC-4 for someone who might need it.

Hi,

Once again thanks for your work on that.

Only two questions remaining.

Hi,

@dgroene, thanks a lot to have updated the MR!

It looks ok.

But I want to give it a longer look and have limited time for now and priority is to release a stable release.

Also now that 4.0.x branch exists, I will have to cherry-pick it.

So I keep this issue for later.

I wonder if the events should be introduced at the pull form level or deeper into the import Service to be also available to CLI usage?

Also needs to create change record for the 2 new events introduced.

I am fine with whichever you prefer. For me, this is all about altering the pull form to add additional information for the content editors to see what they are pulling- the additions to the jsonapi query go hand in hand with altering the pull form. I have not used it with the CLI.

Hi, this looks like the feature I need for my issue 💬 Share entities based on client Active

What would be the steps to use this? Do I just patch the module with #15?

Is there a current way to add a filter to the $prepared_url in the entity_share/modules/entity_share_client/src/Form/PullForm.php?

I could create a custom module but would need a pointer on how to go about hooking into the PullForm please

or, can we release this?

Hi,

I have tested the MR against the 8.x-3.0 branch and was able to create a custom module that subscribes to the event dispatched from this code (JsonApiQueryEvent).

It was then successful in altering the query before the channel request was sent, and able to filter the json results by specifying additional filters from the client side (same filters that can be found in the 'collections' section of the Json API extras).

Would be great if we could release this please :)

Thanks