πŸ‡ΊπŸ‡ΈUnited States @bmcclure

West Virginia
Account created on 17 April 2008, about 16 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

We started experiencing the same issue yesterday.

If I right-click the image and open it in a new tab, sometimes it loads but usually it gets a 502.

I guess Google must have just changed something in the chart API service, or they are having service issues.

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

As far as I can tell, the ability to post tweets in the v1.1 API for the Free tier is gone now.

It stopped working for our Twitter account on 8/22, no other changes were made but we started getting 403 Forbidden responses when the module tries to post a tweet.

I came across this reply from an official account that seems to confirm that their pricing tier documentation is wrong: https://twittercommunity.com/t/authentication-error-when-trying-to-post-...

So assuming that's accurate, this module will probably only work for posting tweets from a premium plan, unless your particular account hasn't lost access yet.

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

With these test results being good, I think this fix is probably ready to go!

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

That makes sense for the reproduction steps, and the approach to the fix looks sound.

I haven't had a chance to test this, so just to confirm, is the test-only patch sufficient to make the test fail without the fix? If so then this seems good to go to me.

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

I'm ashamed that it took me 3 years to get back to you, I'm so sorry to leave you hanging!

I'm assuming you either figured this out or gave up already, but if not, or if anyone else stumbles across this issue looking for an answer, I think the best reference for altering the CSS is the css/float_labels.css file within the module itself.

That has all of the default styling, so anything you want to override, just make sure to use a more specific selector (e.g. add either a parent class or a sibling class to the .float-labels-wrapper selector).

I can try and assist further if you do still need help, just let me know what you'd like to do with the CSS!

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

This has finally been merged in, sorry it took so long, and thank you for your contribution!

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

So sorry it took me forever to get to this! I adjusted it slightly since we don't need it to be translated yet at that stage due to another patch that was merged, but it looks great!

I've merged this fix in. Thank you so much for your contribution!

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

I don't think the two options laid out in #10 are sufficient for all use cases.

For example, we want to show a popup whenever you are going to an external domain that does not end in .gov, but with the current options, I think that would mean having to maintain a list of every possible TLD that it should show up for, which is a challenge since new TLDs are released regularly.

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

bmcclure β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States bmcclure West Virginia

This is extremely useful! Email is sometimes the only reliable way to match up users between different systems, so having the built-in email field for users available to use as a reference greatly simplifies things.

The patch applies cleanly and works great for configuring the feed to reference a user by email. If I run into any issues while running the feed I will report back, but so far this seems great.

Thank you!

Production build 0.69.0 2024