- 🇬🇧United Kingdom Eli-T Manchester
Apologies, patch in #10 no longer applies.
Whilst I'm not opposed to the code quality improvements in this patch, they should be addressed in their own separate issues rather than here where reasonably practical.
- 🇺🇸United States bmcclure West Virginia
I agree, but I've re-rolled the patch from #10 for now to make it apply on the current release.
- 🇳🇿New Zealand davidwhthomas
Thanks for adding this patch, it's needed.
However, after applying on the latest `drupal/views_ef_fieldset:^1.10` release, exposed filters that include exposed operators, such as date fields, do not show inside the configured fieldsets.
- Merge request !21Add support for exposed items_per_page pager in fieldset configuration → (Open) created by davidwhthomas
- 🇳🇿New Zealand davidwhthomas
I added a patch via merge request that only adds support for the exposed
items_per_page
pager without other code updates. - 🇬🇧United Kingdom Eli-T Manchester
Thanks @davidwhthomas!
MR!21 is showing PHPCS failures so putting back to needs work.
https://git.drupalcode.org/issue/views_ef_fieldset-2497845/-/jobs/3481155
- 🇬🇧United Kingdom Eli-T Manchester
If we address the PHPCS issue and folks falling foul of this confirm it works, let's get it merged and in a release - it's been hanging around long enough!
- 🇳🇿New Zealand davidwhthomas
You're welcome. I've added another commit to the MR to tidy up those PHPCS suggestions, with thanks for the useful module.