Genk 🇧🇪
Account created on 7 November 2013, about 11 years ago
#

Merge Requests

Recent comments

🇧🇪Belgium bceyssens Genk 🇧🇪

ivnish,

I updated your role in Git!

🇧🇪Belgium bceyssens Genk 🇧🇪

Hi ivnish,

I just added you as a co-maintainer. All help on the project is welcome!

Kind regards
Brecht Ceyssens

🇧🇪Belgium bceyssens Genk 🇧🇪

Hi Hauke,

Did you find the ResponsiveImageFormatter? https://git.drupalcode.org/project/combined_image_style/-/blob/1.0.x/src...
I also created a formatter for media fields in a project of ours so you can configure combinations for each breakpoint in the display of an entity. No need for responsive images styles. Is that what you're looking for? If so, I can add my work to the project.

🇧🇪Belgium bceyssens Genk 🇧🇪

Code below was missing in the new submit method:

// Force a rebuild of the form.             
$form_state->setRebuild();                  
$form_state->set('tmgmt_suggestions', NULL);

New patch and interdiff attached.

🇧🇪Belgium bceyssens Genk 🇧🇪

Using the form language does the trick

🇧🇪Belgium bceyssens Genk 🇧🇪

hi @finne, your patch is very welcome! I'll have a look at it as soon as I find some time.

🇧🇪Belgium bceyssens Genk 🇧🇪

Replacing incorrect patch

🇧🇪Belgium bceyssens Genk 🇧🇪

I'm not a fan of the hashing solution as you have no idea what the content is. The dictionary looks like a lot of work to maintain.
As an alternative method I added compression strategy, keeping only the first letter of each word. It is fully automated and you could still retrieve the original cache tag.

As you should still have the option to disable minification logic completely, I changed the configuration form to a select.
Example minitication ratios (number of characters in the cache tags header):

  • None: 4030
  • Dictionary: 2337
  • Compress: 1300
  • Hash: 734
🇧🇪Belgium bceyssens Genk 🇧🇪

Applied the same logic to ParagraphsWidget fieldwidget as it is used in the paragraph library.

🇧🇪Belgium bceyssens Genk 🇧🇪

thank you for the patch @flyke

🇧🇪Belgium bceyssens Genk 🇧🇪

Hi @davemybes,
Latest dev version is already D10 compatible: https://git.drupalcode.org/project/tmgmt_lokalise/-/commits/1.0.x

🇧🇪Belgium bceyssens Genk 🇧🇪

Argument(s) could start with -profile of +profile

🇧🇪Belgium bceyssens Genk 🇧🇪

Applied the same "no hijacking" logic for profile as done for colorspace. Patch attached

🇧🇪Belgium bceyssens Genk 🇧🇪

patch #20 seems to work for us with latest 2.x dev version.

🇧🇪Belgium bceyssens Genk 🇧🇪

I think you should use commerce_price form elements instead of number, patch attached.

🇧🇪Belgium bceyssens Genk 🇧🇪

Use the ModuleHandlerInterface instead

🇧🇪Belgium bceyssens Genk 🇧🇪

Adding property to class fixes the issue.

🇧🇪Belgium bceyssens Genk 🇧🇪

Using the AllowDynamicProperties attributes on the Result class fixes the issue for now.

Production build 0.71.5 2024