Fetch tax percentage from config

Created on 30 January 2022, almost 3 years ago
Updated 6 May 2024, 8 months ago

Now hardcoded, it should be fetched from store config.

Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇧🇪Belgium bceyssens Genk 🇧🇪

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇱Netherlands finne Amsterdam

    I would like to get the tax in a more dynamic way: from order/orderLineItem adjustments (or possibly shipment or invoice adjustments). I also see a scenario with different tax amounts, so instead of calculating it in UblBuilder::getBlob() we should probably take the inclusiveAmount and exclusiveAmount and taxAmount from the invoice.

    That way you use whatever method was used to arrive at the tax stated on the invoice.

    I have made a first patch that takes the percentage from the first orderItem Adjustment of the tax type. Far from perfect, but it's a start. I can add it to this issue if people are interested.

  • 🇧🇪Belgium bceyssens Genk 🇧🇪

    hi @finne, your patch is very welcome! I'll have a look at it as soon as I find some time.

  • 🇳🇱Netherlands finne Amsterdam

    Hi @bceyssens, I have added my changes to an issue fork branch.

Production build 0.71.5 2024