This issue has been fixed in release 10.0.2 → .
This issue has been fixed in release 10.0.2 → .
This issue has been fixed in release 10.0.2 → .
This issue has been fixed in release 10.0.2 → .
This issue has been addressed in release 10.0.2 → .
I've reviewed this change in multiple menu sizes and multiple viewport sizes, and I've concluded that it improves the appearance more often than it worsens the appearance. However, the MR is being requested to be merged into an outdated branch 8.x-3.x. Instead the CSS change will be implemented in commit d1977e2d76eed76055a3f921c6caef26b8580759 of the main supported 10.0.x branch.
This will be part of the next release.
This MR suffers from the same breakages described in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
As stated before, Fepper Theme is meant to mostly be a base theme that you can customize with a sub-theme.
I will be closing the MR and this issue.
This MR suffers from the same breakages described in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
I've applied just the fix for the menu being hidden while logged in onto commit fb79b29bc2f90fa28d02adff7b5fb40f6a48e25d.
This will be part of the next release.
This MR suffers from the same breakages described in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
Concerning only the changes to the footer, the same idea applies. Fepper Theme is supposed to be a base theme upon which on a subtheme can be customized. A case in point is the padding around the footer applied by this MR. Not only is it arbitrary, but it doesn't resemble the general consistency of padding in the rest of the theme. Whether it looks good and should be kept is up to subthemers to decide.
This patch is being requested to merge into an old, unsupported branch of Fepper Theme.
I've instead copied the code and inserted it into commit 78f7f05e9af27ef5a2c7ffd6536091c1ff9ce0ad.
This will be part of the next release.
This issue isn't a bug or breakage. While suggestions for aesthetic improvement are greatly appreciated, Fepper Theme is meant to be a base theme, where such improvements are meant to be implemented in a sub-theme.
This is how things look without the patch:
It's a case of being good enough for everyone, where perfection should be up to each implementer.
This merge request suffers from the same breakages noted in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
Instead of merging this request, I've applied improved spacing in https://git.drupalcode.org/project/fepper/-/commit/8d174910bd2af632daeae8c53563058286aa291a.
This will be released in the near future.
This merge request suffers from the same breakages noted in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
Instead of merging this request, I've applied the suggested spacing in https://git.drupalcode.org/project/fepper/-/commit/bff5d4db8527416cf1070...
This will be released in the near future.
Hello again @alok_singh !
As stated before in an earlier issue, Fepper Theme is meant to mostly be a base theme that you can customize with a sub-theme. Numerous issues arise when trying to customize any theme, and the development effort to address those issues often trends toward infinity.
Below are screenshots of your changes applied to small and medium viewports respectively:
screenshot small after changes →
screenshot medium after changes →
Below are screenshot of the same area without your changes, small and medium viewports respectively:
screenshot small before changes →
screenshot medium before changes →
Spacing is applied generically because applying a change in one place, no matter how visually appealing, may break spacing in another place, always unexpectedly, and sometimes dramatically. Somewhat ironically, the generic spacing in Fepper Theme has been carefully thought through and tested in just about every imaginable scenario to avoid breakages.
I will be closing this issue and merge request.
Thanks again!
Hello @alok_singh !
Thank you for your interest in Fepper!
While I appreciate you taking the time to raise this issue and merge request, Fepper Theme is meant to mostly be a base theme that you can customize with a sub-theme. Numerous issues arise when trying to customize any theme, and the development effort to address those issues often trends toward infinity.
For example, your changes applied to a narrow viewport in the screenshot above.
The screenshot below shows how Fepper Theme renders without your changes. Spacing is applied generically because applying a change in one place, no matter how visually appealing, may break spacing in another place, always unexpectedly, and sometimes dramatically.
I will be closing this issue and merge request.
Thanks again!
The suggested backward compatibility has been ported into v10.0.x, the default branch. Closing.
The default branch of Fepper Theme has changed to 10.0.x and the older branches are no longer receiving updates because Drupal 10 will be the only supported version in a few days. These patches are not relevant and the status of this issue needs to reflect that.