- Issue created by @alok_singh
- Merge request !5Fepper 3389708: Footer section is broken need to style. → (Closed) created by alok_singh
- Status changed to Needs review
about 1 year ago 5:14am 26 September 2023 - 🇮🇳India nilesh.k
Hi alok,
I've applied your changes from branch (fepper-3389708) and can confirm that the footer section UI looks good. Please see attached file.
Thank you - Status changed to RTBC
about 1 year ago 7:31pm 28 November 2023 - 🇺🇸United States e2tha-e
This MR suffers from the same breakages described in https://www.drupal.org/project/fepper/issues/3389554 🐛 Need space between two articles. Closed: works as designed .
Concerning only the changes to the footer, the same idea applies. Fepper Theme is supposed to be a base theme upon which on a subtheme can be customized. A case in point is the padding around the footer applied by this MR. Not only is it arbitrary, but it doesn't resemble the general consistency of padding in the rest of the theme. Whether it looks good and should be kept is up to subthemers to decide.
- Status changed to Closed: works as designed
8 months ago 10:39am 23 April 2024