Recent comments

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@alok_singh Sub menus are not allowed by the GOV.UK design System. In fact menus in the header are very much discouraged see the Service navigation component which is implimented in the the new V2.1.x release.

I'm closing this ticket as it is outside the scope of this theme.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@alok_singh This is not allowed by the GOV.UK Design System. See https://design-system.service.gov.uk/components/footer/

By all means impliment this design in your own sub theme but I'm closing this ticket as it's outside the scope of this theme

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@alok_singh The footer menu is correct. See any GOV.UK site. There is only 1 footer menu allowed by the GOV.UK Design System

πŸ‡¬πŸ‡§United Kingdom webfaqtory

webfaqtory β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Changes

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@alok_singh I have completed the Customising Twig templates guide β†’ with an exaple of how to customise pager.html.twig

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@riddhi.addweb This has been resolved in the 8.x-1.21 release with the GOV.UK pagination classes applied to pager.html.twig. Please update to this release and retest.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@alok_singh I have done a new release, 8.x-1.21 that includes the styled pager.html.twig. Still working on the documentation pages β†’

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@riddhi.addweb Can you test with the new 8.x-1.21 release

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@riddhi.addweb Can you test with the new 8.x-1.21 release

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Updates

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Completed all steps

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@riddhi.addweb this is an update to a SASS file. Did you run gulp after applying the MR?
I'm doing a new release today with all the updates, a sub-theme for this theme and D11 compatabilty. Try again with this new release 8.x-1.21. I'll let you know when it's released.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

I don't see any way to fix this. It happens on all sites using the Claro admin theme. It is a background image for the input field.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Added this and will be in next release.
Ideally you would have one About us page and then have the other About us links in a chevron card. See https://www.gov.uk/

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Sub menues are not allowed in the GOV.UK style guide so I'm not sure how to procede with this.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This has been added and will be in the next release.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This is wrong way to achieve this. The GOV.UK classes for pagination need to be added to pager.html.twig. I am adding a page to the theme documentation on how to do this. I will update this issue when this is done.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This has been added and will be in the next release.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This has been added and will be in the next release.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This has been added and will be in the next release.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This has been added and will be in the next release

πŸ‡¬πŸ‡§United Kingdom webfaqtory

This is the WRONG way to do this!!!

style.css is generated when gulp is run and any changes will be lost! Also this change will remove the GOV.UK focus style for all links!

The correct way to do this is to target only the toolbar anchor elements as below:

#toolbar-administration #toolbar-bar .toolbar-tab a:focus {
  background-color: transparent;
}
#toolbar-administration #toolbar-bar .toolbar-tab a.is-active {
  background-color: white;
}

And place this snippet in govuk.css. I have added this to govuk.css and it will be included in the next release.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@greggles . Thought I did that and a release 8.x-1.19 β†’ Haven't done a merge on Drupal before, only merged patches so did I miss something?

πŸ‡¬πŸ‡§United Kingdom webfaqtory

I have discovered that this error is caused by the file_delete module not being installed. This should be a dependency in this modules installation

πŸ‡¬πŸ‡§United Kingdom webfaqtory

@deepak5423 I agree, it's not necessary on the replace file form and can be removed.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

webfaqtory β†’ created an issue.

πŸ‡¬πŸ‡§United Kingdom webfaqtory

I'm trying to add the 10.2.x fork to my composer.json (sorry never done this before) I have this under repositories:

 {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/drupal-2946333.git"
        }

But I don't know what to put under require for the 2946333_3049332_combined-10.2.x branch and would it replace the drupal/core requirement?

πŸ‡¬πŸ‡§United Kingdom webfaqtory

Patch #15 didn't apply for me in D10.2.4. Made a simpler patch that applies in 10.2.4

πŸ‡¬πŸ‡§United Kingdom webfaqtory

I applied the revised patch #327 and still don't get the pencil icon on translated pages when in Layout.

The above is what I get when editing the layout of a translated node on a clean install of D10.2.4. Only the drag/drop icon shows anywhere in the block

Production build 0.71.5 2024