🇺🇸United States @cruno

Fixed in 2.8.1

Made compatible in 2.8 and up.

We're getting the same issue as #5 when running drush config:import in image builds.

TypeError: Drupal\hook_event_dispatcher\HookEventPluginManager::__construct(): Argument #3 ($moduleList) must be of type array, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in /app/web/modules/contrib/hook_event_dispatcher/src/HookEventPluginManager.php on line 35 #0 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(259): Drupal\hook_event_dispatcher\HookEventPluginManager->__construct()
#1 /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php(177): Drupal\Component\DependencyInjection\Container->createService()
#2 /app/web/modules/contrib/hook_event_dispatcher/src/ProxyClass/HookEventPluginManager.php(64): Drupal\Component\DependencyInjection\Container->get()
#3 /app/web/modules/contrib/hook_event_dispatcher/src/ProxyClass/HookEventPluginManager.php(83): Drupal\hook_event_dispatcher\ProxyClass\HookEventPluginManager->lazyLoadItself()
#4 /app/web/modules/contrib/hook_event_dispatcher/src/HookEventDispatcherModuleHandler.php(93): Drupal\hook_event_dispatcher\ProxyClass\HookEventPluginManager->getAlterEventFactories()
#5 /app/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(340): Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler->alter()
#6 /app/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(295): Drupal\Core\Plugin\DefaultPluginManager->alterDefinitions()
#7 /app/web/modules/contrib/config_filter/src/Plugin/ConfigFilterPluginManager.php(70): Drupal\Core\Plugin\DefaultPluginManager->findDefinitions()
#8 /app/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(181): Drupal\config_filter\Plugin\ConfigFilterPluginManager->findDefinitions()
#9 /app/web/modules/contrib/config_filter/src/Plugin/ConfigFilterPluginManager.php(37): Drupal\Core\Plugin\DefaultPluginManager->getDefinitions()
#10 /app/web/modules/contrib/config_filter/src/ConfigFilterStorageFactory.php(88): Drupal\config_filter\Plugin\ConfigFilterPluginManager->getFiltersForStorages()
#11 /app/web/modules/contrib/config_filter/src/ConfigFilterEventSubscriber.php(56): Drupal\config_filter\ConfigFilterStorageFactory->getFilteredStorage()
#12 [internal function]: Drupal\config_filter\ConfigFilterEventSubscriber->onImportTransform()
#13 /app/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()
#14 /app/web/core/lib/Drupal/Core/Config/ImportStorageTransformer.php(120): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#15 /app/vendor/drush/drush/src/Drupal/Commands/config/ConfigImportCommands.php(243): Drupal\Core\Config\ImportStorageTransformer->transform()
#16 [internal function]: Drush\Drupal\Commands\config\ConfigImportCommands->import()
#17 /app/vendor/consolidation/annotated-command/src/CommandProcessor.php(276): call_user_func_array()
#18 /app/vendor/consolidation/annotated-command/src/CommandProcessor.php(212): Consolidation\AnnotatedCommand\CommandProcessor->runCommandCallback()
#19 /app/vendor/consolidation/annotated-command/src/CommandProcessor.php(176): Consolidation\AnnotatedCommand\CommandProcessor->validateRunAndAlter()
#20 /app/vendor/consolidation/annotated-command/src/AnnotatedCommand.php(391): Consolidation\AnnotatedCommand\CommandProcessor->process()
#21 /app/vendor/symfony/console/Command/Command.php(326): Consolidation\AnnotatedCommand\AnnotatedCommand->execute()
#22 /app/vendor/symfony/console/Application.php(1081): Symfony\Component\Console\Command\Command->run()
#23 /app/vendor/symfony/console/Application.php(320): Symfony\Component\Console\Application->doRunCommand()
#24 /app/vendor/symfony/console/Application.php(174): Symfony\Component\Console\Application->doRun()
#25 /app/vendor/drush/drush/src/Runtime/Runtime.php(124): Symfony\Component\Console\Application->run()
#26 /app/vendor/drush/drush/src/Runtime/Runtime.php(51): Drush\Runtime\Runtime->doRun()
#27 /app/vendor/drush/drush/drush.php(79): Drush\Runtime\Runtime->run()
#28 /app/vendor/drush/drush/includes/preflight.inc(18): require('...')
#29 phar:///usr/local/bin/drush/bin/drush.php(143): drush_main()
#30 /usr/local/bin/drush(14): require('...')
#31 {main}

cruno → created an issue.

almunnings → credited cruno → .

Resolved with https://git.drupalcode.org/project/fsa/-/merge_requests/8

cruno → created an issue.

Thanks @imclean this patch fixed the issue.

Gábor Hojtsy → credited cruno → .

Updating the patch again to include the change from isMasterRequest() to isMainRequest() from Symfony http-kernel's KernelEvent.

cruno → created an issue.

Kristen Pol → credited cruno → .

Re-rolling the patch for 4.x without the unit tests for now.

Adding to the automated patch for .info.yml changes.

MR opened - https://git.drupalcode.org/project/fsa/-/merge_requests/7

It looks like the only issues remaining were the .info.yml files. I've updated the automated patch with those additional changes.