undefined - Contrib.social

🇦🇺Australia dabbor

If I got your question right:

The Front Page of Variation Cache ( https://www.drupal.org/project/variationcache → ) says:

This feature is now available in Drupal 10.2! 🚀

Please uninstall and remove this module once you are using Drupal 10.2 or higher and have no more code mentioning the Drupal\variationcache namespace.

Answering the:

Starting with what Drupal version is this in core?

So Drupal 10.2 is the version.

VariationCache release https://www.drupal.org/project/variationcache/releases/8.x-1.5 → provides the following information:

VariationCache is now part of Drupal core 10.2 and up. This release keeps it working on D10.0 and D10.1 but also makes it so it does not collide with D10.2 and actually uses the core classes by virtue of class_alias(). It improves upon 1.4 in that some edge cases regarding kernel events now also work.

🐛 | Access unpublished | Access Unpublished check being called twice

🇦🇺Australia dabbor

🐛 | Access unpublished | Access Unpublished check being called twice

🇦🇺Australia dabbor

Adding in a simple file patch for https://git.drupalcode.org/project/access_unpublished/-/merge_requests/1...

To make referencing in composer safer.

I tested the patch to make sure the Access check in question is not running twice in row + The Access Unpublished Tokens are working OK.

🐛 | Access unpublished | Access Unpublished check being called twice

🇦🇺Australia dabbor

🐛 | Access unpublished | Access Unpublished check being called twice

🇦🇺Australia dabbor

dabbor → created an issue.

🇦🇺Australia dabbor

The work is ready to be reviewed.

✨ | Access unpublished | Support Group v1 content

🇦🇺Australia dabbor

I've created a related ticket: "Support Group 2.x content" https://www.drupal.org/project/access_unpublished/issues/3405874 ✨ Support Group 2.x content Active to adapt the solution to work with Group 2.x which was a significant modification.

I provided new MR in that new related issue + patch and interdiff in my comment: https://www.drupal.org/project/access_unpublished/issues/3405874#comment... ✨ Support Group 2.x content Active

🇦🇺Australia dabbor

Adding a patch of the current MR to be linked in composer (interdiff to work implemented in https://www.drupal.org/project/access_unpublished/issues/3280964 ✨ Support Group content Active .

🇦🇺Australia dabbor

🇦🇺Australia dabbor

dabbor → created an issue.

🐛 | Group Media | Group media 3.0: Missing Group 2.x API change in groupmedia_vbo

🇦🇺Australia dabbor

Coppied the MR patch (https://git.drupalcode.org/project/groupmedia/-/merge_requests/29.patch) to here as a static file patch to be used in composer.json (to not get into problem with potential MR updates).

🐛 | Group Media | Group media 3.0: Missing Group 2.x API change in groupmedia_vbo

🇦🇺Australia dabbor

🐛 | Group Media | Group media 3.0: Missing Group 2.x API change in groupmedia_vbo

🇦🇺Australia dabbor

dabbor → created an issue.

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

Running the drush upgrade_status:analyze gcontent_moderation (using the https://www.drupal.org/project/upgrade_status → contrib to check D10 compatibility), I found:

A.) mistake in composer.json not being valid and I fixed it, hence the new patch.

B.) Problem with: Call to deprecated method prophesize(), but I can not fix it just easily as there's not specify how to replace the usage. Searching online I haven't found it withing reasonable time. It is not even clear if it needs to be replaced for D10 compatibility or it is just an upgrade_status bug (as mentioned in some comments I found):

/gcontent_moderation/tests/src/Kernel/ContentModerationIntegr
ationTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 132  Call to deprecated method prophesize() of class             
                    PHPUnit\Framework\TestCase:                                 
                    https://github.com/sebastianbergmann/phpunit/issues/4141    
--------------------------------------------------------------------------------
Check manually 138  Call to deprecated method prophesize() of class             
                    PHPUnit\Framework\TestCase:                                 
                    https://github.com/sebastianbergmann/phpunit/issues/4141    
--------------------------------------------------------------------------------

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

Here's an update patch from #22 that is against 1.x-dev and thus D10 compatible.

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

I've updated the patch from #22 to include the "Automated Drupal 10 compatibility fixes" from https://www.drupal.org/project/gcontent_moderation/issues/3297291 📌 Automated Drupal 10 compatibility fixes Fixed making it possible to run gcontent_moderation with Group 2.x / 3.x on D10.

The patch is done against 1.0.0-beta2 and NOT the 1.x-dev.

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

Following the conversation above I agree with #20:

I recommend merging this MR on a new major version (e.g. 2.x) which will be compatible with Group 2.x and 3.x

I believe it's clear this module must support (move to) Group 2.x / 3.x for the following reasons:

The 8.x-1.x version of Group receives only Security
Anyone using Group contrib planning future for his project will need to receive more than Security fixes.
Though the 8.x-1.x version info file states it is compatible with Drupal 10 (https://git.drupalcode.org/project/group/-/blob/8.x-1.x/group.info.yml), the description of the project page states otherwise:
Branch | Core support | Status
8.x-1.x | Drupal 8 / 9 | Security fixes only
Recently merged D10 compatibility fixes ( https://www.drupal.org/project/gcontent_moderation/issues/3297291 📌 Automated Drupal 10 compatibility fixes Fixed ) currently in dev branch 1.x-dev#46bd24592 should get release soon, is not compatible with this patch here (we will have to update it here anyway if we are not getting a separate 2.x branch (stream) for it.

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

Following the information from Updating your modules to Group 2.0 API "Database structure" section https://www.drupal.org/docs/contributed-modules/group/updating-your-modu... → , the group_content_field_data must be replaced with group_relationship_field_data and the current patch from #16 is missing it.

The table name must be replaced in Views sql JOIN's aliases as well, e.g. group_relationship_field_data_node_field_data . Example of such Views LEFT JOIN:

LEFT JOIN "group_relationship_field_data" "group_relationship_field_data_media_field_data" ON media_field_data.mid = group_relationship_field_data_media_field_data.entity_id AND group_relationship_field_data_media_field_data.plugin_id IN ( :views_join_condition_0__0, :views_join_condition_0__1, :views_join_condition_0__2, :views_join_condition_0__3, :views_join_condition_0__4 )

I'm attaching a patch that adds the required change on top of the patch from #16.

✨ | Group Content Moderation | Provide moderation transition permissions per node type

🇦🇺Australia dabbor

Reviewing the Merge request 10 https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/... I doubt it can work with the Group 2.x (though I might be missing something) as Group 2.x migrated from GroupContentPermissionProvider (/src/Plugin/GroupContentPermissionProvider.php) to GroupMembershipPermissionProvider (/src/Plugin/Group/RelationHandler/GroupMembershipPermissionProvider.php) in the commit https://git.drupalcode.org/project/group/-/commit/84da85bbcb30827d3660af...

At some point I was thinking that I might just need to apply the patch in different order, but thinking about it a bit and testing it to be sure, it doesn't make any difference, so applying the patching in following or reverse order results in the same and the GroupContentPermissionProvider usage is still there, which is wrong.

"drupal/gcontent_moderation": {
                "Is group content moderation module compatible with Groups 2.0.0-beta3? - https://www.drupal.org/project/gcontent_moderation/issues/3309542#comment-15044265": "https://www.drupal.org/files/issues/2023-05-10/3309542-16.patch",
                "Provide moderation transition permissions per node type - ": "https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/10.diff"
            }

🐛 | Page Manager | Path has unnecessary query appended.

🇦🇺Australia dabbor

I've tested the patch from #28 and reviewed it closely.

It is breaking page access for us on various pages and links (like breadcrumbs).

I agree with @L_VanDamme:

This does feel a lot like a bandaid for a bigger issue though, more investigation would be nice. Especially by someone more familiar with the routing system and the way parameters are being upcast to objects.

The /page_manager/src/Routing/PageManagerRoutes.php needs more work and testing.

I also doubt that the page_manager_page.view string should be changed to version with underscore _page_manager_page.view as it’s an access request and the change refers to something not existing.

This is the line change I'm talking about /page_manager/src/Routing/PageManagerRoutes.php

$requirements['_page_access'] = '_page_manager_page.view';

📌 | Group Content Moderation | Add compatibility with Group 2.x

🇦🇺Australia dabbor

It would be good to get the patch merged as it is not exactly easy to properly manage the module via composer when using Group 2.x and this patch from #16: https://www.drupal.org/project/gcontent_moderation/issues/3309542#commen... 💬 Is group content moderation module compatible with Groups 2.0.0-beta3? Needs work though you will most likely need to create a new branch compatible with Group 2.x.

The problem is that composer is looking into modules's composer.json for requirements before the patch is applied to switch requirements from Group 1.x to Group 2.x.

I had to use the following workaround inspired by StackOverflow: Is it possible to ignore child dependencies in Composer config? https://stackoverflow.com/a/53970732

    "repositories": [
        {
            "type": "package",
            "package": {
                "name": "custom/gcontent_moderation",
                "version": "1.0.0-beta2",
                "dist": {
                    "type": "zip",
                    "url": "https://ftp.drupal.org/files/projects/gcontent_moderation-1.0.0-beta2.zip",
                    "reference": "1.0.0-beta2"
                },
                "require": {
                    "drupal/core": "^8.8 || ^9",
                    "drupal/group": "^2.0"
                },
                "autoload": {
                    "classmap": ["."]
                }
            }
        }
    ],

I'm not sure yet about the bit:

"autoload": {
    "classmap": ["."]
}

it might need to get removed.

🐛 | Page Manager | Path has unnecessary query appended.