Contrib.social

Support Group v1 content

Open on Drupal.org →
Created on 17 May 2022, almost 3 years ago
Updated 7 August 2024, 9 months ago

Problem/Motivation

I believe because of the way Groups handles access control, even if you generate an access token for a piece of Group content, Groups isn't aware of this it will deny access. In my testing I could not get access_unpublished to work for any content which belongs to a group.

Steps to reproduce

Install Group, Group Node, and Access Unpublished. Setup a Group Type, and add allow content type to it. Create group content of that type. Create a link with Access Unpublished - it will result in Access Denied.

Proposed resolution

I think Group's access control model needs to be extended per documentation at https://www.drupal.org/docs/contributed-modules/group/extending-groups-a... → . In that overridden access control handler, it will need to check with access_unpublished_entity_access and use that as the access result. I have implemented this as a proof of concept - will submit a PR on drupalcode.

Remaining tasks

Code review - especially permissions handling. Test coverage.

User interface changes

The proof of concept adds group level permissions so access_unpublished can be allowed per group type and group role.

API changes

N/A

Data model changes

N/A

✨ Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States msielski

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇦🇺Australia dabbor

    I've created a related ticket: "Support Group 2.x content" https://www.drupal.org/project/access_unpublished/issues/3405874 ✨ Support Group 2.x content Active to adapt the solution to work with Group 2.x which was a significant modification.

    I provided new MR in that new related issue + patch and interdiff in my comment: https://www.drupal.org/project/access_unpublished/issues/3405874#comment... ✨ Support Group 2.x content Active

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update over 1 year ago
    10 pass, 2 fail
  • Comment over 1 year ago →
    🇺🇸United States DamienMcKenna NH, USA

    There's a patch and merge request, so let's update the status.

  • Comment 9 months ago →
    bilele123123

    May I ask if anyone is running into this error?

    LogicException: Cannot use an "access" handler without a "permission_provider" handler. in Drupal\group\Plugin\GroupContentAccessControlHandler::createInstance() (line 41 of modules/composer/group/src/Plugin/GroupContentAccessControlHandler.php).

    Drupal\group\Plugin\GroupContentEnablerManager->createHandlerInstance('Drupal\access_unpublished_group\Plugin\AccessUnpublishedGroupContentAccessControlHandler', 'group_menu:menu', Array) (Line: 141)
    Drupal\group\Plugin\GroupContentEnablerManager->getHandler('group_menu:menu', 'access') (Line: 166)
    Drupal\group\Plugin\GroupContentEnablerManager->getAccessControlHandler('group_menu:menu') (Line: 351)
    group_entity_access(Object, 'view', Object)
    call_user_func_array(Object, Array) (Line: 409)
    Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'group') (Line: 388)

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024