- Issue created by @dylan donkersgoed
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22last update
almost 2 years ago Waiting for branch to pass - @dylan-donkersgoed opened merge request.
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org βCore: 9.5.x + Environment: PHP 7.3 & MariaDB 10.3.22last update
almost 2 years ago Waiting for branch to pass - @dylan-donkersgoed opened merge request.
- π¨π¦Canada dylan donkersgoed London, Ontario
I've attached a couple MRs. One applies the part from the original patch that adds support for this, one is for the 2.x version of group and would need to be used in combination with https://www.drupal.org/project/gcontent_moderation/issues/3309542 π¬ Is group content moderation module compatible with Groups 2.0.0-beta3? Needs work .
- Status changed to Needs review
almost 2 years ago 6:20pm 29 May 2023 - π¨π¦Canada dylan donkersgoed London, Ontario
Forgot to mention when I created the issue but I think the person who added these changes to the original patch was Austin Mitchell β , please credit him as well if this is merged in.
- π¦πΊAustralia dabbor
Reviewing the Merge request 10 https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/... I doubt it can work with the Group 2.x (though I might be missing something) as Group 2.x migrated from GroupContentPermissionProvider (
/src/Plugin/GroupContentPermissionProvider.php
) to GroupMembershipPermissionProvider (/src/Plugin/Group/RelationHandler/GroupMembershipPermissionProvider.php
) in the commit https://git.drupalcode.org/project/group/-/commit/84da85bbcb30827d3660af...At some point I was thinking that I might just need to apply the patch in different order, but thinking about it a bit and testing it to be sure, it doesn't make any difference, so applying the patching in following or reverse order results in the same and the GroupContentPermissionProvider usage is still there, which is wrong.
"drupal/gcontent_moderation": { "Is group content moderation module compatible with Groups 2.0.0-beta3? - https://www.drupal.org/project/gcontent_moderation/issues/3309542#comment-15044265": "https://www.drupal.org/files/issues/2023-05-10/3309542-16.patch", "Provide moderation transition permissions per node type - ": "https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/10.diff" }
- last update
over 1 year ago 4 pass - πΊπΈUnited States recrit
attached a static patch of the group 1.x MR 9 at commit #cd417f44
- last update
over 1 year ago 4 fail - last update
over 1 year ago 4 fail