Duplicate of https://www.drupal.org/project/bankid_oidc/issues/3407318 📌 Automated Drupal 10 compatibility fixes Needs review
Released 2.0.0-beta1 →
Duplicate of https://www.drupal.org/project/bisnode/issues/3407347 📌 Automated Drupal 10 compatibility fixes Needs review
All changes make sense to me.
esolitos → made their first commit to this issue’s fork.
I wish Drupal would embrace a documental database such as Elasticsearch as content storage <3
Thanks for this nice module @phayes!
No worries, I'm aware that php 7.4 is EOL.
Thanks for the quick turnaround!
jwilson3 → credited esolitos → .
esolitos → created an issue.
esolitos → created an issue.
Thank you for the fixes! :)
esolitos → created an issue.
PS: I added a commit which simply removed the "@alpha" requirement, mostly to ensure you got credited. :)
PR accepted, merged and new a release is set up.
Thanks for the contribution!
And sorry - I hadn't realised you maintained the Drupal module and the upstream library!
No worries. :)
Thank you for the feedback, much appreciated.
I reviewed the PR on esolitos/pwnedpasswords, I've added a small suggestion to maintain compatibility.
Hi, thanks for taking the time with the feedback.
When using ssg, processing happens each time, with a rebuild taken place if the queue is empty.
The highlighted part is the core problem we wanted to highlight, this command cannot simply run every few minutes, because at some point the queue will be empty and it will start the process all over again.
Regarding your suggestion:
If you want to deterministically regenerate all sitemaps each day, increase the Sitemap generation max duration setting to something very high (30 seconds?), and run ssg once a day.
Our generation takes well above 30 seconds as we are dealing with millions of content entities. ^_^
Other than that there is a vast amount of API functions available to help you build a drush command in a custom module. Let me know if you need any pointers.
We are aware that we can build our custom implementation, but we wanted to contribute back to this module as we use it quite extensively.
Our plan would be to implement an additional command (for example simple-sitemap:process) which only processes the queue and if it is empty simply exits, much like the drush queue:run command.
And of course we plan to maintain the current functionality of simple-sitemap:generate.
The main point we wanted to make here is that we are implementing this already for our own usage, however we think this is a valuable addition to this already great module, we wanted to know if this is is something which would be interested reviewing and adding.
Opened MR!1
esolitos → created an issue.