- Issue created by @nicrodgers
- Assigned to nicrodgers
- 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
I've created a PR for the upstream dependency here https://github.com/esolitos/pwnedpasswords/pull/2
- @nicrodgers opened merge request.
- Status changed to Needs work
over 1 year ago 7:09pm 11 May 2023 - 🇳🇴Norway esolitos Trondheim
Thank you for the feedback, much appreciated.
I reviewed the PR onesolitos/pwnedpasswords
, I've added a small suggestion to maintain compatibility. - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:18am 12 May 2023 - 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
Thanks for the feedback. And sorry - I hadn't realised you maintained the Drupal module and the upstream library! That's great, it certainly makes this much easier. So once the upstream MR is merged, we can close the d.o fork down and mark this as fixed, because nothing should be needed on the Drupal side.
- Status changed to Fixed
over 1 year ago 10:34am 12 May 2023 - 🇳🇴Norway esolitos Trondheim
PR accepted, merged and new a release is set up.
Thanks for the contribution!
And sorry - I hadn't realised you maintained the Drupal module and the upstream library!
No worries. :)
-
nicrodgers →
authored aa2ae364 on 8.x-1.x
Issue #3359629 by nicrodgers: Drupal 10 / Guzzle 7 compatibility
-
nicrodgers →
authored aa2ae364 on 8.x-1.x
- 🇳🇴Norway esolitos Trondheim
PS: I added a commit which simply removed the "@alpha" requirement, mostly to ensure you got credited. :)
Automatically closed - issue fixed for 2 weeks with no activity.