- Issue created by @esolitos
- last update
about 1 year ago 5 pass - @esolitos opened merge request.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:08am 20 September 2023 - 🇪🇨Ecuador jwilson3
My apologies that you've hit this issue. The end of life date for PHP 7.4 was November 28, 2022.
Some context:
- Drupal is moving towards allowing trailing commas in multi-line functions and methods here: #3295249: Allow multi-line function declarations → .
- Enterprise hosting platforms like Acquia have already phased out PHP 7. (Acquia is providing long-term support through Oct 2023).
- Even low-end hosting like Dreamhost have also phased PHP 7 out.
We have to decide whether to add back PHP 7.4 support with this (admittedly trivial) fix or to leave this issue open and let the folks on old versions just use the patch. Will discuss with co-maintainer @mandclu and make a decision.
- Status changed to Fixed
about 1 year ago 5:54am 21 September 2023 - 🇪🇨Ecuador jwilson3
I've discussed this with Martin and we've agreed that the best approach is to merge this PR, and tag it in a 2.2.2 release, then rever that change, add a PHP minimum version requirement in our composer, and tag a 2.3.0 release. (I'll create a follow-up issue for that part.)
Users on PHP 7.4 will then be able to properly use composer to install the correct version without errors.
- last update
about 1 year ago 5 pass -
jwilson3 →
committed 17291c92 on 2.2.x authored by
esolitos →
Issue #3388449 by esolitos, jwilson3, mandclu: Usage of trailing comma...
-
jwilson3 →
committed 17291c92 on 2.2.x authored by
esolitos →
- 🇪🇨Ecuador jwilson3
I've created the follow-up: 📌 Version 2.3 of SVG Image Field should require PHP 8 Active
- 🇳🇴Norway esolitos Trondheim
No worries, I'm aware that php 7.4 is EOL.
Thanks for the quick turnaround!
Automatically closed - issue fixed for 2 weeks with no activity.