πŸ‡¬πŸ‡§United Kingdom @Dan.Ashdown

Account created on 18 March 2011, over 13 years ago
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

This reason this was an issue for us was that this overwrote our normal page title altering.

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Dan.Ashdown β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Thanks for the feedback @fago! Updated to document the parameter and support BC.

I've also moved it to an MR.

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

This is a duplicate of https://www.drupal.org/project/lupus_decoupled/issues/3353654 πŸ› Frontpage ce-api request with query params returns not found Fixed

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Closing as this is actually part of https://www.drupal.org/project/lupus_decoupled/issues/3354572 πŸ› Views: Fix rendering rows to leverage the CE generator Fixed

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Replaced by https://www.drupal.org/project/lupus_decoupled/issues/3340520#comment-14... πŸ“Œ Views support Fixed

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Replaced by https://www.drupal.org/project/lupus_decoupled/issues/3340520#comment-14... πŸ“Œ Views support Fixed

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Outstanding feedback still to be addressed.

  1. https://www.drupal.org/project/custom_elements/issues/3333832#comment-14... πŸ“Œ Support Views Closed: won't fix
  2. https://www.drupal.org/project/custom_elements/issues/3333832#comment-14... πŸ“Œ Support Views Closed: won't fix
  3. https://www.drupal.org/project/lupus_ce_renderer/issues/3333827#comment-... πŸ“Œ Support Views Closed: won't fix
  4. https://www.drupal.org/project/lupus_ce_renderer/issues/3333827#comment-... πŸ“Œ Support Views Closed: won't fix
πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Thanks for the feedback @fago

I've updated the MR to render other blocks. See the new screenshot showing a system block and a global content block.

Having 1 large iframe would be better for that, also speed would improve. As you say though that would mean replicating all the LB interactivity within Vue. I.e. the drag and drop, contextual links, moving blocks between page sections etc which would need to broadcast this back to the parent frame, which would require a bunch of glue code to work with Drupal's LB JS. Personally I think that would be lovely but not an insignificant undertaking (I think this is what you mean that Franz is working on?). I think that could come later?

We're using Tailwind so don't have the issue of needing dom hierarchy for styling but appreciate that a lot of sites will need this. What do you think about adding another URL parameter on the iframe src that allows you to add additional View templates.
i.e. the Vue template is currently /node/_node/layout/_uuid/_.vue The _.vue currently represents the view_mode. If instead we had /node/_node/layout/_uuid/_view_mode/_.vue The _.vue would be the default, but you could add annother template e.g. /node/_node/layout/_uuid/_view_mode/sidebar.vue which contained the appropriate wrapping divs and classes etc. This could be supported by a hook in lupus_decoupled_layout_builder_preprocess_block() that allowed the template name to be set based on the block data?

Thoughts?

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Sounds good @fago, will action the above feedback from you both.

Production build 0.69.0 2024